Add a config variable to override default container registry instead of dockerhub.#10166
Merged
liushilongbuaa merged 5 commits intosonic-net:masterfrom Mar 14, 2022
Merged
Conversation
liushilongbuaa
force-pushed
the
default-acr
branch
2 times, most recently
from
0a0b2d9 to
329e9e4
Compare
liushilongbuaa
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
Collaborator
|
@liushilongbuaa , thanks for the contribution to make the container registry endpoint configurable. |
xumia
reviewed
Mar 9, 2022
xumia
reviewed
Mar 9, 2022
liushilongbuaa
force-pushed
the
default-acr
branch
from
ceed546 to
b4c47ce
Compare
liushilongbuaa
force-pushed
the
default-acr
branch
from
819358c to
3412042
Compare
Contributor
Author
test finished. |
xumia
reviewed
Mar 11, 2022
xumia
approved these changes
Mar 14, 2022
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Mar 17, 2022
…of dockerhub. (sonic-net#10166) * Add variable to reset default docker registry * fix bug in docker version control
Merged
6 tasks
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Mar 17, 2022
…of dockerhub. (sonic-net#10166) * Add variable to reset default docker registry * fix bug in docker version control
Merged
6 tasks
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Mar 17, 2022
…of dockerhub. (sonic-net#10166) * Add variable to reset default docker registry * fix bug in docker version control
Merged
6 tasks
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Jun 13, 2022
…of dockerhub. (sonic-net#10166) * Add variable to reset default docker registry * fix bug in docker version control
liushilongbuaa
added a commit
that referenced
this pull request
Jun 22, 2022
* [ci] Set default ACR in UpgrateVersion/PR/official pipeline. (#10341) Why I did it docker hub will limit the pull rate. Use ACR instead to pull debian related docker image. How I did it Set DEFAULT_CONTAINER_REGISTRY in pipeline. * Add a config variable to override default container registry instead of dockerhub. (#10166) * Add variable to reset default docker registry * fix bug in docker version control
StormLiangMS
pushed a commit
to StormLiangMS/sonic-buildimage
that referenced
this pull request
Jul 18, 2022
…et#11002) * [ci] Set default ACR in UpgrateVersion/PR/official pipeline. (sonic-net#10341) Why I did it docker hub will limit the pull rate. Use ACR instead to pull debian related docker image. How I did it Set DEFAULT_CONTAINER_REGISTRY in pipeline. * Add a config variable to override default container registry instead of dockerhub. (sonic-net#10166) * Add variable to reset default docker registry * fix bug in docker version control
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Add a config variable DEFAULT_CONTAINER_REGISTRY to override default container registry.
How I did it
It can be set in config file and can be overridden by command line.
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)