[Build]: Fix /proc not mounted issue#10164
Merged
xumia merged 1 commit intosonic-net:masterfrom Mar 11, 2022
Merged
Conversation
qiluo-msft
reviewed
Mar 8, 2022
qiluo-msft
approved these changes
Mar 11, 2022
Collaborator
qiluo-msft
left a comment
There was a problem hiding this comment.
LGTM. Please wait a while for other reviewers.
Collaborator
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Mar 16, 2022
[Build]: Fix /proc not mounted issue
6 tasks
Collaborator
Author
@qiluo-msft , thanks for the notice, I have sent a new PR #10256 to fix the conflict. |
xumia
added a commit
that referenced
this pull request
Mar 19, 2022
judyjoseph
pushed a commit
that referenced
this pull request
Mar 20, 2022
[Build]: Fix /proc not mounted issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
It does not make sense to unmount /proc in the slave container.
It has impact multiple programs, for example:
Another example, the slave container will become unreachable when /proc unmounted.
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)