Skip to content

[Build]: Fix /proc not mounted issue#10164

Merged
xumia merged 1 commit intosonic-net:masterfrom
xumia:fix-proc-issue
Mar 11, 2022
Merged

[Build]: Fix /proc not mounted issue#10164
xumia merged 1 commit intosonic-net:masterfrom
xumia:fix-proc-issue

Conversation

@xumia
Copy link
Collaborator

@xumia xumia commented Mar 7, 2022

Why I did it

It does not make sense to unmount /proc in the slave container.

It has impact multiple programs, for example:

root@8f495bfec510:/# umount /proc
root@8f495bfec510:/# ps -a       
Error, do this: mount -t proc proc /proc

Another example, the slave container will become unreachable when /proc unmounted.

$ docker exec 8f495bfec510 uname -m
OCI runtime exec failed: exec failed: container_linux.go:346: starting container process caused "close exec fds: open /proc/self/fd: no such file or directory": unknown

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@xumia xumia requested a review from lguohan as a code owner March 7, 2022 08:14
@xumia xumia added the Build label Mar 7, 2022
@xumia xumia changed the title Fix /proc not mounted issue [Build]: Fix /proc not mounted issue Mar 7, 2022
@xumia xumia requested a review from qiluo-msft March 8, 2022 01:54
Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please wait a while for other reviewers.

@xumia xumia merged commit 9cdf812 into sonic-net:master Mar 11, 2022
@xumia xumia deleted the fix-proc-issue branch March 11, 2022 01:23
@qiluo-msft
Copy link
Collaborator

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Mar 16, 2022
[Build]: Fix /proc not mounted issue
@xumia
Copy link
Collaborator Author

xumia commented Mar 16, 2022

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

@qiluo-msft , thanks for the notice, I have sent a new PR #10256 to fix the conflict.

xumia added a commit that referenced this pull request Mar 19, 2022
[Build]: Fix /proc not mounted issue
judyjoseph pushed a commit that referenced this pull request Mar 20, 2022
[Build]: Fix /proc not mounted issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants