[yang] Fixing Ethertype field regex in acl rule yang to accept decimal values#10108
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Mar 17, 2022
Merged
Conversation
Collaborator
Author
|
/azpw run Azure.docker-slave-buster-arm64 |
Collaborator
|
/AzurePipelines run Azure.docker-slave-buster-arm64 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@qiluo-msft , @praveen-li kindly reminder to review and signoff. This is issue for 202111. |
dgsudharsan
added
the
Request for 202111 Branch
keboliu
approved these changes
Mar 15, 2022
ganglyu
reviewed
Mar 16, 2022
| "eStrKey" : "Pattern" | ||
| }, | ||
| "ACL_RULE_L2_INVALID_ETHER": { | ||
| "desc": "Configure invalid MAC address format.", |
Contributor
There was a problem hiding this comment.
why do you remove the UT for invalid MAC address?
Collaborator
Author
There was a problem hiding this comment.
I didn't remove any UT. I just corrected the description which was wrong.
ganglyu
approved these changes
Mar 16, 2022
qiluo-msft
changed the title
Contributor
|
There are merge conflicts, please raise a new PR for 202111 |
judyjoseph
removed
the
Request for 202111 Branch
dgsudharsan
added
Request for 202111 Branch
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Mar 21, 2022
…l values (sonic-net#10108) Fixing issue sonic-net#9991 The ACL RULE table field ETHER_TYPE can accept both hex as well as decimal values. However yang model didn't allow decimal values. Fixed it to allow decimal values (same pattern as in hex (1536-65535) Updated yang model to handle decimal values Added UT to verify it.
6 tasks
Collaborator
Author
Raised here #10306 |
liat-grozovik
pushed a commit
that referenced
this pull request
Apr 10, 2022
…t decimal values (#10306) Cherry-pick #10108 - Why I did it Fixing issue #9991 The ACL RULE table field ETHER_TYPE can accept both hex as well as decimal values. However yang model didn't allow decimal values. Fixed it to allow decimal values (same pattern as in hex (1536-65535) - How I did it Updated yang model to handle decimal values - How to verify it Added UT to verify it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Fixing issue #9991
The ACL RULE table field ETHER_TYPE can accept both hex as well as decimal values. However yang model didn't allow decimal values. Fixed it to allow decimal values (same pattern as in hex (1536-65535)
How I did it
Updated yang model to handle decimal values
How to verify it
Added UT to verify it.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)