[build] fix build exception and revert #9136#10037
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Feb 21, 2022
Merged
[build] fix build exception and revert #9136#10037qiluo-msft merged 2 commits intosonic-net:masterfrom
qiluo-msft merged 2 commits intosonic-net:masterfrom
Conversation
This reverts commit 5ce75ac.
qiluo-msft
previously approved these changes
Feb 19, 2022
Contributor
|
@ghooo, @qiluo-msft So, the main issue should be fixed issues/9312. |
qiluo-msft
approved these changes
Feb 21, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
This is because Jinja2 uses MarkupSafe without specifying an upper limit to the version, MarkupSafe version that was released today removed 'soft_unicode'. So now Jinja2 is complaining.
Related issues:
pallets/jinja#1591
aws/aws-sam-cli#3661
Fixing build failures in SONiC utils example
One of the errors:
The VLAN_MEMBER backlink (can be called referrer link or ref link) is not found.
Issue introduced by #9136
I don't know how this PR passed the build system, it should have failed.
Known YANG issue #9312
How I did it
The import to
sonic-vlanis breaking the buildI am not sure if that's the only issue, so I think reverting the whole PR should be the safer option.
How to verify it
Ran sonic-utils tests locally.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)