[DPB] | printed output for dependencies on a port is unclear

[slutati1536]

Description

1. printed output for dependencies on a port is unclear, not all the dependencies are printed, and when configuring breakout with force there is no dependencies list printed as a warning.
2. the word "Dependecies" in output is misspelled. Dependecies -> Dependencies
3. "Do you wish to Continue? [y/N]:" appears twice in the output, which means the flag -y isn't serving its purpose of ignoring questions for the user. when -y flag has been applied no question should be asked.
4. why have the port breakout resulted printed twice? (Ports to be deleted/Ports to be added and
   Final list of ports to be deleted/Final list of ports to be added), it should only be printed once.

Steps to reproduce the issue:

1. sudo config portchannel add PortChannel0001
2. sudo config portchannel member add PortChannel0001 Ethernet212
3. sudo config vlan add 1536
4. sudo config vlan member add 1536 Ethernet212
5. show vlan brief
6. show interfaces portchannel
7. show interfaces status
8. sudo config interface breakout Ethernet212 4x25G[10G,1G] -y (-f)

Describe the results you received:

sudo config interface breakout Ethernet212 4x25G[10G,1G] -y

Running Breakout Mode : 1x100G[50G,40G,25G,10G,1G] 
Target Breakout Mode : 4x25G[10G,1G]

Ports to be deleted : 
 {
    "Ethernet212": "100000"
}
Ports to be added : 
 {
    "Ethernet212": "25000",
    "Ethernet213": "25000",
    "Ethernet214": "25000",
    "Ethernet215": "25000"
}

After running Logic to limit the impact

Final list of ports to be deleted : 
 {
    "Ethernet212": "100000"
} 
Final list of ports to be added :  
 {
    "Ethernet212": "25000",
    "Ethernet213": "25000",
    "Ethernet214": "25000",
    "Ethernet215": "25000"
}
Loaded below Yang Models
['sonic-acl', 'sonic-breakout_cfg', 'sonic-crm', 'sonic-device_metadata', 'sonic-device_neighbor', 'sonic-extension', 'sonic-flex_counter', 'sonic-interface', 'sonic-loopback-interface', 'sonic-port', 'sonic-portchannel', 'sonic-types', 'sonic-versions', 'sonic-vlan']
Note: Below table(s) have no YANG models:
FEATURE, SNMP_COMMUNITY, SNMP, PORTCHANNEL_MEMBER, TELEMETRY, 
Below Config can not be verified, It may cause harm to the system
 {
  "PORTCHANNEL_MEMBER": {
    "PortChannel0001|Ethernet212": {}
  }
}
Do you wish to Continue? [y/N]: y
Dependecies Exist. No further action will be taken
*** Printing dependecies ***
/sonic-vlan:sonic-vlan/VLAN_MEMBER/VLAN_MEMBER_LIST[vlan_name='Vlan1536'][port='Ethernet212']/port

Only the VLAN dependency was printed after "*** Printing dependecies ***" when trying to configure without force.

sudo config interface breakout Ethernet212 4x25G[10G,1G] -y -f

Running Breakout Mode : 1x100G[50G,40G,25G,10G,1G] 
Target Breakout Mode : 4x25G[10G,1G]

Ports to be deleted : 
 {
    "Ethernet212": "100000"
}
Ports to be added : 
 {
    "Ethernet212": "25000",
    "Ethernet213": "25000",
    "Ethernet214": "25000",
    "Ethernet215": "25000"
}

After running Logic to limit the impact

Final list of ports to be deleted : 
 {
    "Ethernet212": "100000"
} 
Final list of ports to be added :  
 {
    "Ethernet212": "25000",
    "Ethernet213": "25000",
    "Ethernet214": "25000",
    "Ethernet215": "25000"
}
Loaded below Yang Models
['sonic-acl', 'sonic-breakout_cfg', 'sonic-crm', 'sonic-device_metadata', 'sonic-device_neighbor', 'sonic-extension', 'sonic-flex_counter', 'sonic-interface', 'sonic-loopback-interface', 'sonic-port', 'sonic-portchannel', 'sonic-types', 'sonic-versions', 'sonic-vlan']
Note: Below table(s) have no YANG models:
FEATURE, SNMP_COMMUNITY, SNMP, PORTCHANNEL_MEMBER, TELEMETRY, 
Below Config can not be verified, It may cause harm to the system
 {
  "PORTCHANNEL_MEMBER": {
    "PortChannel0001|Ethernet212": {}
  }
}
Do you wish to Continue? [y/N]: y
Breakout process got successfully completed.
Please note loaded setting will be lost after system reboot. To preserve setting, run `config save`.

when configuring with force the VLAN dependent is not even printed as a warning.

Describe the results you expected:

sudo config interface breakout Ethernet212 4x25G[10G,1G] -y

Running Breakout Mode : 1x100G[50G,40G,25G,10G,1G] 
Target Breakout Mode : 4x25G[10G,1G]

Ports to be deleted : 
 {
    "Ethernet212": "100000"
}
Ports to be added : 
 {
    "Ethernet212": "25000",
    "Ethernet213": "25000",
    "Ethernet214": "25000",
    "Ethernet215": "25000"
}


Loaded below Yang Models
['sonic-acl', 'sonic-breakout_cfg', 'sonic-crm', 'sonic-device_metadata', 'sonic-device_neighbor', 'sonic-extension', 'sonic-flex_counter', 'sonic-interface', 'sonic-loopback-interface', 'sonic-port', 'sonic-portchannel', 'sonic-types', 'sonic-versions', 'sonic-vlan']
Note: Below table(s) have no YANG models:
FEATURE, SNMP_COMMUNITY, SNMP, PORTCHANNEL_MEMBER, TELEMETRY, 

Dependencies Exist. No further action will be taken
*** Printing  dependencies ***
/sonic-vlan:sonic-vlan/VLAN_MEMBER/VLAN_MEMBER_LIST[vlan_name='Vlan1536'][port='Ethernet212']/port
/sonic-port-channel/..../[port-channel_name="PortChannel0001"][port='Ethernet212']/port

Additional information you deem important (e.g. issue happens only occasionally):
Output of show version:

SONiC Software Version: SONiC.dpb_qa_image.0-23134a64
Distribution: Debian 10.7
Kernel: 4.19.0-9-2-amd64
Build commit: 23134a64
Build date: Fri Jan 15 08:52:11 UTC 2021
Built by: vadymh@r-build-sonic03

Platform: x86_64-mlnx_msn3420-r0
HwSKU: ACS-MSN3420
ASIC: mellanox
ASIC Count: 1
Serial Number: MT2019X13878
Uptime: 12:09:49 up  2:35,  2 users,  load average: 4.51, 2.42, 2.09

Docker images:
REPOSITORY                    TAG                       IMAGE ID            SIZE
docker-syncd-mlnx             dpb_qa_image.0-23134a64   72cd4f0bad6c        540MB
docker-syncd-mlnx             latest                    72cd4f0bad6c        540MB
docker-sflow                  dpb_qa_image.0-23134a64   070e94ad45b1        465MB
docker-sflow                  latest                    070e94ad45b1        465MB
docker-snmp                   dpb_qa_image.0-23134a64   4513d9bbede9        436MB
docker-snmp                   latest                    4513d9bbede9        436MB
docker-dhcp-relay             dpb_qa_image.0-23134a64   e9f74defdbed        402MB
docker-dhcp-relay             latest                    e9f74defdbed        402MB
docker-teamd                  dpb_qa_image.0-23134a64   4432208a6469        463MB
docker-teamd                  latest                    4432208a6469        463MB
docker-nat                    dpb_qa_image.0-23134a64   b0f25765961f        466MB
docker-nat                    latest                    b0f25765961f        466MB
docker-router-advertiser      dpb_qa_image.0-23134a64   875949f0ef94        395MB
docker-router-advertiser      latest                    875949f0ef94        395MB
docker-platform-monitor       dpb_qa_image.0-23134a64   77567d9ce67c        683MB
docker-platform-monitor       latest                    77567d9ce67c        683MB
docker-lldp                   dpb_qa_image.0-23134a64   9bba135a3864        435MB
docker-lldp                   latest                    9bba135a3864        435MB
docker-database               dpb_qa_image.0-23134a64   ae8be589a33c        394MB
docker-database               latest                    ae8be589a33c        394MB
docker-sonic-mgmt-framework   dpb_qa_image.0-23134a64   9f7fe89d1421        608MB
docker-sonic-mgmt-framework   latest                    9f7fe89d1421        608MB
docker-orchagent              dpb_qa_image.0-23134a64   5928b24d51e3        481MB
docker-orchagent              latest                    5928b24d51e3        481MB
docker-macsec                 dpb_qa_image.0-23134a64   b255f6b0ccf1        466MB
docker-macsec                 latest                    b255f6b0ccf1        466MB
docker-sonic-telemetry        dpb_qa_image.0-23134a64   4e502f1867fd        469MB
docker-sonic-telemetry        latest                    4e502f1867fd        469MB
docker-fpm-frr                dpb_qa_image.0-23134a64   684115a1f6cc        480MB
docker-fpm-frr                latest                    684115a1f6cc        480MB

**Attach debug file `sudo generate_dump`:**

dpb_output.txt

[praveen-li]

It says

Note: Below table(s) have no YANG models:
FEATURE, SNMP_COMMUNITY, SNMP, PORTCHANNEL_MEMBER, TELEMETRY, 
Below Config can not be verified, It may cause harm to the system
 {
  "PORTCHANNEL_MEMBER": {
    "PortChannel0001|Ethernet212": {}
  }
}

So you need to add YANG models for PORTCHANNEL_MEMBER

[anshuv-mfst]

Enhancement request to add portchannel member YANG model.

[praveen-li]

@slutati1536 Dell has confirmed to raise PR for portchannel_member table yang models, I will wait till Monday, else I will raise PR. Thx.

[zhenggen-xu]

So based on the DPB WG meeting, two issues:
1, Let's print the final ports to be deleted/added ONLY by default . and make the initial ports list into verbose mode.
2, Add portchannel_member yang models.

[anshuv-mfst]

@slutati1536 - PR#7020 is merged, could you please confirm and close the issue?