Edge-core as7312-54X SFP tx_power issue

[joraff]

Description

On accton/edge-core as7312-54X platform, we are unable to get a link with any Q/SFP/+ optical module we have tried. Passive DAC cables are fine. We are able to read the eeprom of the modules.

The i2c nodes for sfp control seem to have changed. Possibly in the CPLD driver? I observe this by trying to use the platform-specific script:

# accton_as7312_util.py set sfp 1 0
Failed :echo 0 >/sys/bus/i2c/devices/18-0050/sfp_tx_disable

# ls -la /sys/bus/i2c/devices/18-0050/
total 0
drwxr-xr-x 3 root root     0 Feb 16 11:05 .
drwxr-xr-x 6 root root     0 Feb 14 10:12 ..
-rw-r--r-- 1 root root  4096 Feb 14 14:19 dev_class
lrwxrwxrwx 1 root root     0 Feb 14 14:19 driver -> ../../../../../../bus/i2c/drivers/optoe
-rw-r--r-- 1 root root 33152 Feb 14 10:18 eeprom
-r--r--r-- 1 root root  4096 Feb 14 14:19 modalias
-r--r--r-- 1 root root  4096 Feb 14 14:19 name
-rw-r--r-- 1 root root  4096 Feb 14 14:19 port_name
drwxr-xr-x 2 root root     0 Feb 14 14:19 power
lrwxrwxrwx 1 root root     0 Feb 14 10:12 subsystem -> ../../../../../../bus/i2c
-rw-r--r-- 1 root root  4096 Feb 14 10:12 ueven

Steps to reproduce the issue:

1. Insert optical SFP (any form factor) module into an enabled port
2. Double check port speed and admin enabled status
3. Observe link status

Describe the results you received:
No link achieved. TX_disable pin possibly not being disabled

Describe the results you expected:
Link achieved, TX_disable status being disabled on plugin, or by using platform-specific control script accton_as7312_util.py .

Output of show version:

$ show version

SONiC Software Version: SONiC.master.447-bef76b10
Distribution: Debian 10.6
Kernel: 4.19.0-9-2-amd64
Build commit: bef76b10
Build date: Sat Oct 17 09:50:26 UTC 2020
Built by: johnar@jenkins-worker-8

Platform: x86_64-accton_as7312_54x-r0
HwSKU: Accton-AS7312-54X
ASIC: broadcom
Serial Number: 731254X1727010
Uptime: 04:20:19 up 4 days, 18:08,  1 user,  load average: 4.47, 3.19, 2.72

Docker images:
REPOSITORY                    TAG                   IMAGE ID            SIZE
docker-teamd                  latest                5c592b65e21d        396MB
docker-teamd                  master.447-bef76b10   5c592b65e21d        396MB
docker-sonic-mgmt-framework   latest                f85eacaccd94        486MB
docker-sonic-mgmt-framework   master.447-bef76b10   f85eacaccd94        486MB
docker-router-advertiser      latest                a153afc17879        359MB
docker-router-advertiser      master.447-bef76b10   a153afc17879        359MB
docker-platform-monitor       latest                408344f9a0bc        443MB
docker-platform-monitor       master.447-bef76b10   408344f9a0bc        443MB
docker-lldp                   latest                8ecf97c3f689        391MB
docker-lldp                   master.447-bef76b10   8ecf97c3f689        391MB
docker-dhcp-relay             latest                7f0488fd7b0a        366MB
docker-dhcp-relay             master.447-bef76b10   7f0488fd7b0a        366MB
docker-database               latest                45e3750c14db        359MB
docker-database               master.447-bef76b10   45e3750c14db        359MB
docker-orchagent              latest                c061654f8a96        410MB
docker-orchagent              master.447-bef76b10   c061654f8a96        410MB
docker-nat                    latest                24899834e99d        399MB
docker-nat                    master.447-bef76b10   24899834e99d        399MB
docker-sonic-telemetry        latest                29a2e0e1c787        429MB
docker-sonic-telemetry        master.447-bef76b10   29a2e0e1c787        429MB
docker-fpm-frr                latest                e20e2b0974c8        413MB
docker-fpm-frr                master.447-bef76b10   e20e2b0974c8        413MB
docker-sflow                  latest                1a71bf3e2eed        400MB
docker-sflow                  master.447-bef76b10   1a71bf3e2eed        400MB
docker-snmp                   latest                a00953c0ef4e        399MB
docker-snmp                   master.447-bef76b10   a00953c0ef4e        399MB
docker-syncd-brcm             latest                d5e9f792d448        542MB
docker-syncd-brcm             master.447-bef76b10   d5e9f792d448        542MB

Note: the issue is present on 202006, as well as master. I have not tried older releases. The support file is also too big to post. Lmk if it's needed and I can host it somewhere.

[joraff]

For anyone else coming here:

$ sudo find /sys -name "*tx_disable*" | sort
/sys/devices/pci0000:00/0000:00:1f.3/i2c-1/i2c-5/5-0062/module_tx_disable_1
/sys/devices/pci0000:00/0000:00:1f.3/i2c-1/i2c-5/5-0062/module_tx_disable_10
/sys/devices/pci0000:00/0000:00:1f.3/i2c-1/i2c-5/5-0062/module_tx_disable_11
/sys/devices/pci0000:00/0000:00:1f.3/i2c-1/i2c-5/5-0062/module_tx_disable_12
/sys/devices/pci0000:00/0000:00:1f.3/i2c-1/i2c-5/5-0062/module_tx_disable_13
/sys/devices/pci0000:00/0000:00:1f.3/i2c-1/i2c-5/5-0062/module_tx_disable_14
...

Seems so elementary now, but there are literally zero google results with that i2c path.

$ echo 0 | sudo tee /sys/devices/pci0000:00/0000:00:1f.3/i2c-1/i2c-5/5-0062/module_tx_disable_1

and the interface comes up.

Edge-core team, can you read this and update the platform scripts?

[roylee123]

Hi joraff, refer to #5941 for the fix.

[joraff]

I appreciate the fix! Working great now. Is there a suggested method for persisting the setting between reboots?

[roylee123]

This is a customized script for accton switches, it's not supported by sonic-cfggen.
But you may put your setting at the end of do_install() of accton_as7312_util.py.