Make openbmp support redis subscription/population on sonic. by FengPan-Frank · Pull Request #7 · sonic-net/sonic-bmp

FengPan-Frank · 2024-04-09T10:38:01Z

Work item tracking
Microsoft ADO (number only):27184382

Make openbmp support redis subscription/population on sonic.

This PR contains below changes:

Use -DENABLE_REDIS=ON to make openbmp support sonic redis population, without -DENABLE_REDIS=ON it keeps its original openbmp functionality/dependency, both of two path verification have been covered by current azure pipeline.
Support BMP_STATE_DB specific table population per users' config via CONFIG_DB, config cli.
Work together with bmpcfgd daemon Add bmpcfgd for monitoring config_db state change. sonic-host-services#121, and the detail workflow is as below:
3.1 bmpcfgd will be daemon which subscribe config_db table enablement, like bgp_neighbor_table/bgp_rib_in_table/bgp_rib_out_table, once config is changed, bmpcfgd will stop openbmpd, clear bmp related tables, then restart openbmpd
3.2 openbmpd will be daemon which accept connection from bgp, and populate BMP_STATE_DB for relevant bmp table like BGP_NEIGHBOR, etc.
Integrate with swss-common library.

Server/src/openbmp.cpp

Server/src/client_thread.cpp

Server/src/openbmp.cpp

Server/src/redis/MsgBusImpl_redis.cpp

Server/src/RedisManager.h

Server/src/redis/MsgBusImpl_redis.cpp

Server/src/RedisManager.cpp

…nk/sonic-openbmp into fenpan_openbmp_redis

… into fenpan_openbmp_redis

…nk/sonic-openbmp into fenpan_openbmp_redis

xincunli-sonic · 2024-11-01T23:42:38Z

Server/src/RedisManager.cpp

+        LOG_INFO("RedisManager %s is disabled", table.c_str());
+        return false;
+    }
+    std::unique_ptr<swss::Table> stateBMPTable = std::unique_ptr<swss::Table>(new swss::Table(stateDb_.get(), table));


new swss::Table

Consider using std::make_uniqueswss::Table instead of new to create unique pointers. #Closed

updated, and upgraded into c++14 correspondingly, seems swss-common uses c++14 as well.

xincunli-sonic · 2024-11-01T23:43:41Z

Server/src/RedisManager.cpp

+/*********************************************************************//**
+ * Constructor for class
+ ***********************************************************************/
+RedisManager::~RedisManager() {


~RedisManager()

The destructor ~RedisManager() is currently empty. Ensure that any dynamically allocated resources are properly managed, or consider removing the destructor if no custom cleanup is required. #Closed

no resource to be cleanup now and could be used as place holder.

xincunli-sonic · 2024-11-01T23:44:58Z

Server/src/RedisManager.cpp

+    std::unique_ptr<swss::Table> stateBMPTable = std::unique_ptr<swss::Table>(new swss::Table(stateDb_.get(), table));
+    std::string fullKey;
+    for (const auto& key : keys) {
+        fullKey += key;


+=

Consider using std::ostringstream or std::accumulate to improve readability and efficiency. #Closed

xincunli-sonic · 2024-11-01T23:46:40Z

Server/src/RedisManager.cpp

+
+    DEBUG("RedisManager WriteBMPTable key = %s", fullKey.c_str());
+
+    stateBMPTable->set(fullKey, fieldValues);


fieldValues

Suggest to log this values or size of it for future tracebility in complex scenarios #Closed

added more debug log into MsgBusImpl_redis class for more constructive looking, which triggers this WriteBMPTable()

Server/src/RedisManager.cpp

…nk/sonic-openbmp into fenpan_openbmp_redis

xincunli-sonic

LGTM

FengPan-Frank · 2024-11-06T06:24:21Z

/azpw run Azure.sonic-bmp

mssonicbld · 2024-11-06T06:24:22Z

/AzurePipelines run Azure.sonic-bmp

azure-pipelines · 2024-11-06T06:24:31Z

Azure Pipelines successfully started running 1 pipeline(s).

FengPan-Frank · 2024-11-06T06:48:07Z

/AzurePipelines run Azure.sonic-bmp

azure-pipelines · 2024-11-06T06:48:15Z

Azure Pipelines successfully started running 1 pipeline(s).

FengPan-Frank · 2024-11-08T10:59:28Z

/AzurePipelines run Azure.sonic-bmp

azure-pipelines · 2024-11-08T10:59:38Z

Azure Pipelines successfully started running 1 pipeline(s).

…nk/sonic-openbmp into fenpan_openbmp_redis

FengPan-Frank requested review from liuh-80 and qiluo-msft April 9, 2024 10:38

FengPan-Frank mentioned this pull request Apr 9, 2024

[HLD] bmp for monitoring SONiC BGP info sonic-net/SONiC#1621

Merged

FengPan-Frank force-pushed the fenpan_openbmp_redis branch from a2918c1 to 283d443 Compare April 9, 2024 14:31

Make openbmp support redis subscription/population on sonic.

f3dc99b

FengPan-Frank force-pushed the fenpan_openbmp_redis branch from 283d443 to f3dc99b Compare April 18, 2024 23:25