[pbh] dynamic implementation inner hashing#824
Merged
liat-grozovik merged 3 commits intosonic-net:masterfrom Oct 31, 2021
Merged
[pbh] dynamic implementation inner hashing#824liat-grozovik merged 3 commits intosonic-net:masterfrom
liat-grozovik merged 3 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Anton <antonh@nvidia.com>
AntonHryshchuk
force-pushed
the
pbh_tests
branch
from
56fb9a4 to
8fa7462
Compare
4 tasks
4 tasks
Collaborator
|
@anish-n kindly reminder. please review/approve. |
Contributor
Author
|
@anish-n kindly reminder. please review/approve |
Signed-off-by: Anton <antonh@nvidia.com>
Signed-off-by: Anton <antonh@nvidia.com>
Collaborator
|
@anish-n could you please signoff? |
anish-n
approved these changes
Oct 28, 2021
Contributor
anish-n
left a comment
anish-n
left a comment
There was a problem hiding this comment.
I suggested a couple of coverage improvements on the sonic-mgmt PR, leaving those comments here too, to be included in a future PR:
- Test coverage for multiple interface types
- Test coverage for all possible match fields in pbh_rule
liat-grozovik
approved these changes
Oct 31, 2021
liat-grozovik
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Nov 8, 2021
…shing configurations (#4078) Extending of inner hashing test with dynamic Policy Base Hashing configurations. Include 4 parameterized tests: * outer_ipver - inner_ipver * ipv4 - ipv4 * ipv6 - ipv4 * ipv6 - ipv4 * ipv6 - ipv6 - How did you verify/test it? The test executed on different Nvidia platforms, supported the PBH feature - Supported testbed topology if it's a new test case? t0 - Documentation sonic-net/SONiC#824
AntonHryshchuk
added a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
…shing configurations (sonic-net#4078) Extending of inner hashing test with dynamic Policy Base Hashing configurations. Include 4 parameterized tests: * outer_ipver - inner_ipver * ipv4 - ipv4 * ipv6 - ipv4 * ipv6 - ipv4 * ipv6 - ipv6 - How did you verify/test it? The test executed on different Nvidia platforms, supported the PBH feature - Supported testbed topology if it's a new test case? t0 - Documentation sonic-net/SONiC#824
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anton antonh@nvidia.com