Add 'device', 'no-zero' options for pcie-aer sub commands#720
Merged
sujinmkang merged 2 commits intosonic-net:masterfrom Jan 5, 2021
Merged
Add 'device', 'no-zero' options for pcie-aer sub commands#720sujinmkang merged 2 commits intosonic-net:masterfrom
sujinmkang merged 2 commits intosonic-net:masterfrom
Conversation
Contributor
ArunSaravananBalachandran
commented
Dec 7, 2020
- Add 'device', 'no-zero' options for pcie-aer sub commands
- Change key format for PCIe device in STATE DB
Collaborator
|
@ArunSaravananBalachandran can we have an example of non-zero option case? can we have non-zero information display as default and display all device-id information with "-verbose" option? |
Contributor
Author
@sujinmkang, please find below the sample output with and without using non-zero option Sure, we can have non-zero output as default |
Contributor
Author
|
@sujinmkang, please find below the updated behavior based on the comments provided and request your review on the same: |
sujinmkang
approved these changes
Jan 5, 2021
sujinmkang
pushed a commit
to sonic-net/sonic-platform-daemons
that referenced
this pull request
Jan 26, 2021
In pcied, added support to collect AER stats belonging to different severities for AER supported PCIe devices and update it in STATE_DB. The key used to represent a PCIE device for storing its AER stats in STATE_DB is of the format PCIE_DEVICE|<Bus>:<Dev>.<Fn>. For every device, AER stats will be stored as key, value pairs where key is of the format <severity>|<AER Error type> and the device ID will be stored with key id. HLD: sonic-net/SONiC#678, sonic-net/SONiC#720 Depends on: sonic-net/sonic-platform-common#144
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.