Layer 2 forwarding enhancements HLD by anilkpandey · Pull Request #379 · sonic-net/SONiC

anilkpandey · 2019-05-09T01:00:42Z

The document provides high level design for enhancements in SONiC layer 2 forwarding for FDB flush, MAC move, FDB aging time configuration, Static FDB configuration and VLAN Range configuration.

PRs:

sonic-net/sonic-sairedis#510
sonic-net/sonic-swss-common#303
sonic-net/sonic-utilities#529
sonic-net/sonic-swss#1716

The documents decribes the functional spec and high level design for Layer 2 Forwarding Enhancements.

msftclas · 2019-05-09T01:00:54Z

All CLA requirements met.

Changed FDB flush mechanism from individual FDB entry delete to Bulk flush in hardware.

Updated to exclude bridge_port_id in Orchagent FDB data structure as it is not needed for bulk flush. We only need the FDB type.

some minor corrections.

chainwu · 2019-05-21T20:30:56Z

Could you also help to fix CLI "show mac" takes too much time to display mac entries, e.g. It will take more than 30+ mins to display 32K entries output? Thanks!

Wilson @loshihyu

anilkpandey · 2019-05-21T22:28:59Z

Hi Wilson, We are able to bring this time down significantly. We will share the fix with community. Thanks. Anil

…

On Tue, May 21, 2019 at 1:31 PM Chain-Wu Lee ***@***.***> wrote: Could you also help to fix CLI "show mac" takes too much time to display mac entries, e.g. It will take more than 30+ mins to display 32K entries output? Thanks! Wilson — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#379>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALLPOUJDQ6WFRHBQSM5YQO3PWRLY3ANCNFSM4HLWJRCQ> .

loshihyu · 2019-05-21T22:39:26Z

That's great! Thanks Anil!

Wilson

1. Added per port per VLAN fdb clear option. 2. Listed all the SAI attributes being used. 3. Added -w option in VLAN Range commands to indicate logging of warning messages.

doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md

stcheng

could you remove all the .DS_Store files?

anilkpandey · 2019-06-13T06:57:45Z

could you remove all the .DS_Store files?

Done

doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md

Updated default FDB aging time.

qiluo-msft

Please also check other reviewers' comments

prsunny · 2019-07-16T17:17:45Z

@keboliu , @madhupalu , can you review/approve this?. Looks like all the open comments are addressed.

* Layer 2 Forwarding Enhancements FDS The documents decribes the functional spec and high level design for Layer 2 Forwarding Enhancements. * Layer 2 Forwarding Enhancements HLD * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update SONiC Layer 2 Forwarding Enhancements HLD.md * Update .DS_Store * Update .DS_Store * Updated to change FDB flush as bulk flush in hardware Changed FDB flush mechanism from individual FDB entry delete to Bulk flush in hardware. * exclude bridge_port_id in fdb data structure Updated to exclude bridge_port_id in Orchagent FDB data structure as it is not needed for bulk flush. We only need the FDB type. * exclude bridge_port_id in fdb data structure * Update SONiC Layer 2 Forwarding Enhancements HLD.md some minor corrections. * Updated with inputs from community review 1. Added per port per VLAN fdb clear option. 2. Listed all the SAI attributes being used. 3. Added -w option in VLAN Range commands to indicate logging of warning messages. * remove .DS_Store * Update SONiC Layer 2 Forwarding Enhancements HLD.md Updated default FDB aging time.

William-zx · 2019-12-18T09:17:22Z

Hi Anil,

Are there any plans to write ansible or pytest scripts to test those enhancements. @anilkpandey

Thanks.
william-zx

anilkpandey · 2019-12-18T23:42:40Z

Hi William,

pytest scripts are added as part of the following PR:

sonic-net/sonic-swss#885

William-zx · 2019-12-19T07:40:51Z

Hi Anil,

It seems you have added some VS tests to test this enhancements. I also want to know if there are any plans to write test cases for this enhancements in sonic-mgmt

Thanks.
william-zx

anilkpandey · 2019-12-20T05:38:45Z

No, only VS pytest.

William-zx · 2019-12-20T09:48:21Z

Thanks Anil! I see.

william-zx

wendani · 2020-09-21T03:44:04Z

doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md

+
+
+**Changes for Static FDB configuration.**
+New CLI will be added for configuring Static FDB entry. It will be set in the FDB_TABLE in CONFIG_DB. Vlanmgr will handle the CONIG_DB changes, do necessary validations and then populate in APP_DB. FdbOrch already has all the necessary handling for Static FDB changes from APP_DB.


I am curious When a static FDB entry is removed from CLI, will SAI notify a SAI_FDB_EVENT_AGED to orchagent?

From images/staticMacConfig.jpg, even if such an event is present, orchagent will ignore it

yes, SAI_FDB_EVENT_AGED will be received and it will be ignored at orchagent because the fdb entry does not exist anymore.

anilkpandey added 28 commits May 7, 2019 15:25

Layer 2 Forwarding Enhancements FDS

df8cd4b

The documents decribes the functional spec and high level design for Layer 2 Forwarding Enhancements.

Layer 2 Forwarding Enhancements HLD

84ac376

Update SONiC Layer 2 Forwarding Enhancements HLD.md

338c526

Update SONiC Layer 2 Forwarding Enhancements HLD.md

2ba476d

Update SONiC Layer 2 Forwarding Enhancements HLD.md

0e33fd7

Update SONiC Layer 2 Forwarding Enhancements HLD.md

3e59927

Update SONiC Layer 2 Forwarding Enhancements HLD.md

dc7d777

Update SONiC Layer 2 Forwarding Enhancements HLD.md

2f6c89b

Update SONiC Layer 2 Forwarding Enhancements HLD.md

ae3a797

Update SONiC Layer 2 Forwarding Enhancements HLD.md

83a691c

Update SONiC Layer 2 Forwarding Enhancements HLD.md

f260189

Merge branch 'master' of https://github.com/anilkpandey/SONiC

550699f

Update SONiC Layer 2 Forwarding Enhancements HLD.md

16b0a31

Update SONiC Layer 2 Forwarding Enhancements HLD.md

deb1c22

Update SONiC Layer 2 Forwarding Enhancements HLD.md

ffb0333

Update SONiC Layer 2 Forwarding Enhancements HLD.md

9b34b8a

Update SONiC Layer 2 Forwarding Enhancements HLD.md

e7af7f9

Update SONiC Layer 2 Forwarding Enhancements HLD.md

9b6db6b

Update SONiC Layer 2 Forwarding Enhancements HLD.md

26b1366

Update SONiC Layer 2 Forwarding Enhancements HLD.md

98683c0

Update SONiC Layer 2 Forwarding Enhancements HLD.md

d025fc9

Update SONiC Layer 2 Forwarding Enhancements HLD.md

1f37ca7

Update SONiC Layer 2 Forwarding Enhancements HLD.md

c4f70f9

Update SONiC Layer 2 Forwarding Enhancements HLD.md

b65cae4

Update SONiC Layer 2 Forwarding Enhancements HLD.md

86c4737

Update SONiC Layer 2 Forwarding Enhancements HLD.md

ab3c3fc

Update SONiC Layer 2 Forwarding Enhancements HLD.md

34f4ca2

Update SONiC Layer 2 Forwarding Enhancements HLD.md

2a58ed7

anilkpandey changed the title ~~High level design for layer 2 forwarding enhancements~~ Layer 2 forwarding enhancements HLD May 9, 2019

anilkpandey added 5 commits May 9, 2019 15:51

Update .DS_Store

c7afd86

Updated to change FDB flush as bulk flush in hardware

2f83a8d

Changed FDB flush mechanism from individual FDB entry delete to Bulk flush in hardware.

exclude bridge_port_id in fdb data structure

24b37aa

Updated to exclude bridge_port_id in Orchagent FDB data structure as it is not needed for bulk flush. We only need the FDB type.

exclude bridge_port_id in fdb data structure

d04ceb7

Update SONiC Layer 2 Forwarding Enhancements HLD.md

819e184

some minor corrections.

Updated with inputs from community review

46631c6

1. Added per port per VLAN fdb clear option. 2. Listed all the SAI attributes being used. 3. Added -w option in VLAN Range commands to indicate logging of warning messages.

madhupalu reviewed Jun 7, 2019

View reviewed changes

stcheng suggested changes Jun 12, 2019

View reviewed changes

remove .DS_Store

56a91b1

stcheng approved these changes Jul 10, 2019

View reviewed changes

prsunny mentioned this pull request Jul 10, 2019

[fdborch] support mac update sonic-net/sonic-swss#877

Merged

qiluo-msft reviewed Jul 11, 2019

View reviewed changes

doc/layer2-forwarding-enhancements/SONiC Layer 2 Forwarding Enhancements HLD.md Outdated Show resolved Hide resolved

keboliu reviewed Jul 12, 2019

View reviewed changes

Update SONiC Layer 2 Forwarding Enhancements HLD.md

8497bc5

Updated default FDB aging time.

qiluo-msft approved these changes Jul 15, 2019

View reviewed changes

prsunny approved these changes Jul 15, 2019

View reviewed changes

keboliu approved these changes Jul 17, 2019

View reviewed changes

prsunny merged commit d4dacee into sonic-net:master Jul 17, 2019

wendani reviewed Sep 21, 2020

View reviewed changes



		Changes for Static FDB configuration.
		New CLI will be added for configuring Static FDB entry. It will be set in the FDB_TABLE in CONFIG_DB. Vlanmgr will handle the CONIG_DB changes, do necessary validations and then populate in APP_DB. FdbOrch already has all the necessary handling for Static FDB changes from APP_DB.

Conversation

anilkpandey commented May 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msftclas commented May 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chainwu commented May 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anilkpandey commented May 21, 2019 via email

Uh oh!

loshihyu commented May 21, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stcheng left a comment

Choose a reason for hiding this comment

Uh oh!

anilkpandey commented Jun 13, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qiluo-msft left a comment

Choose a reason for hiding this comment

Uh oh!

prsunny commented Jul 16, 2019

Uh oh!

William-zx commented Dec 18, 2019

Uh oh!

anilkpandey commented Dec 18, 2019

Uh oh!

William-zx commented Dec 19, 2019

Uh oh!

anilkpandey commented Dec 20, 2019

Uh oh!

William-zx commented Dec 20, 2019

Uh oh!

wendani Sep 21, 2020

Choose a reason for hiding this comment

Uh oh!

anilkpandey Sep 21, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

anilkpandey commented May 9, 2019 •

edited

Loading

msftclas commented May 9, 2019 •

edited

Loading

chainwu commented May 21, 2019 •

edited

Loading