Merged
Conversation
Contributor
|
@dmaltz: FYI, the other pull request you reference (to add the image file) was not created against the master branch of this (Azure) repo. It appears to be created against the master branch of your personal fork (dmaltz#1). Please either create a new pull request here, or simply add the image into this PR, as the two commits are very much related. Thanks! |
Contributor
|
@jleveque , I have cherry-picked that one. Now it is showing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add the sonic logo to the landing page. This commit depends on a previous pull request to add the sonic logo to the images directory. Let's approve and merge that one first, then we can mess with this one more.