Add HLD for Reboot support BlockingMode in SONiC#2016

Merged

Blueve merged 9 commits intosonic-net:masterfrom

lityu:dev/lityu/local

Sep 3, 2025

Contributor

lityu commented Jun 13, 2025 •

edited

Loading

We are trying to introduce blocking mode for reboot script, which currently is in non-blocking mode. This will make automation system easier to identify whether the reboot operation is success.

Code and test PRs:
Add BlockingMode for Reboot script by lityu · Pull Request #3958 · sonic-net/sonic-utilities
Add test plan for reboot blocking mode by lityu · Pull Request #19600 · sonic-net/sonic-mgmt

lityu added 2 commits

June 11, 2025 16:00


          Add HLD for Reboot support BlockingMode in SONiC

f5071f6


          resolve comments

7242a57

Collaborator

mssonicbld commented Jun 13, 2025

/azp run

azure-pipelines bot commented Jun 13, 2025

No pipelines are associated with this pull request.


          Since original reboot batch don't support long parameter, so use -b i…

a0f49f0

…nstead

Collaborator

mssonicbld commented Jun 13, 2025

/azp run

azure-pipelines bot commented Jun 13, 2025

No pipelines are associated with this pull request.


          Fix comments

6895b5b

Collaborator

mssonicbld commented Jun 16, 2025

/azp run

azure-pipelines bot commented Jun 16, 2025

No pipelines are associated with this pull request.


          Resolve comments

105a0bb

Collaborator

mssonicbld commented Jun 18, 2025

/azp run

azure-pipelines bot commented Jun 18, 2025

No pipelines are associated with this pull request.


          Resolve comments

2c23574

Collaborator

mssonicbld commented Jun 30, 2025

/azp run

azure-pipelines bot commented Jun 30, 2025

No pipelines are associated with this pull request.

lityu mentioned this pull request

Add BlockingMode for Reboot script sonic-net/sonic-utilities#3958

Merged


          resolve comments

f7cdba2

Collaborator

mssonicbld commented Jul 8, 2025

/azp run

Blueve changed the title ~~Add HLD for Reboot support BlockingMode in SONiCDev/lityu/local~~ Add HLD for Reboot support BlockingMode in SONiC


          Resolve comments

9f71c92

Collaborator

mssonicbld commented Aug 4, 2025

/azp run

azure-pipelines bot commented Aug 4, 2025

No pipelines are associated with this pull request.

lizhijianrd reviewed

View reviewed changes

doc/reboot/Reboot_BlockingMode_HLD.md Outdated Show resolved Hide resolved

doc/reboot/Reboot_BlockingMode_HLD.md Outdated Show resolved Hide resolved


          fix comments

24e6b50

Collaborator

mssonicbld commented Aug 7, 2025

/azp run

azure-pipelines bot commented Aug 7, 2025

No pipelines are associated with this pull request.

lizhijianrd approved these changes

View reviewed changes

Contributor

bmridul commented Sep 2, 2025

Do we have code PRs for the changes proposed in this HLD? Can you add them to the PR description.

bmridul reviewed

View reviewed changes

doc/reboot/Reboot_BlockingMode_HLD.md Show resolved Hide resolved

Contributor

Blueve commented Sep 2, 2025

note: CONFIG_DB could be helpful in ZTP scenario and user might not want to touch file system --- from Brad

Contributor

Blueve commented Sep 2, 2025

Jing (MSFT) :

The conf is mainly for clarifying the default behavior of reboot script.
You can treat it as a series of default parameter to a CLI

gnoi scenario:

The gnoi API need to be well defined. It is not good to rely on config_db to define its behavior as it will create more confusion and complexity. e.g.

style 1:
/system/ping
{
   ...
   count = 3; // number of pkts
   ...
}

style 2:
good:
/system/ping
//// read [count] from CONFIG_DB/PING_CONF/COUNT

I would prefer the style 1 which is clearer to me

ztp scenario:

If ZTP been used, then CLI reboot is not supposed to be used as normal operation approach.
But the admin might hope config the default reboot CLI behavior through ZTP and then make the operator's CLI operations more robust. It could be a valid scenario, but the benefit is less as the user can always perform what they want to perform in CLI mode.

anilpannala added this to SONiC 202511 Release

zhangyanzhao requested a review from yxieca

September 3, 2025 05:07

Collaborator

zhangyanzhao commented Sep 3, 2025

@yxieca @Blueve can you please help to merge this PR? Thanks.

Blueve merged commit ae00906 into sonic-net:master

1 check passed

Blueve pushed a commit to sonic-net/sonic-utilities that referenced this pull request


          Add BlockingMode for Reboot script (#3958)

63364a3

What I did
Add blocking-mode for the reboot script.

How I did it
sonic-net/SONiC#2016

How to verify it
Local test and introduce test case for reboot script

Previous command output (if the output of a command-line utility has changed)
reboot

New command output (if the output of a command-line utility has changed)
reboot [-b]

YairRaviv pushed a commit to YairRaviv/sonic-utilities that referenced this pull request


          Add BlockingMode for Reboot script (sonic-net#3958)

82e820e

What I did
Add blocking-mode for the reboot script.

How I did it
sonic-net/SONiC#2016

How to verify it
Local test and introduce test case for reboot script

Previous command output (if the output of a command-line utility has changed)
reboot

New command output (if the output of a command-line utility has changed)
reboot [-b]

anilpannala moved this to ✅ Done in SONiC 202511 Release

eddieruan-alibaba pushed a commit that referenced this pull request


          Add HLD for Reboot support BlockingMode in SONiC (#2016)

9a95bcc

We are trying to introduce blocking mode for reboot script, which currently is in non-blocking mode. This will make automation system easier to identify whether the reboot operation is success.

Signed-off-by: Eddie Ruan <eddie.ruan@alibaba-inc.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet