Add HLD for FRR-SONiC Communication Channel Enhancements#1620
Conversation
cscarpitta
force-pushed
the
frr-sonic-communication-channel-enhancements
branch
3 times, most recently
from
ad47b95 to
dc8e158
Compare
Signed-off-by: Carmine Scarpitta <[email protected]>
cscarpitta
force-pushed
the
frr-sonic-communication-channel-enhancements
branch
from
dc8e158 to
82033e7
Compare
|
@cscarpitta , can you please check the following?
|
| * The FRR zebra daemon must load the FPM Protobuf module during startup. | ||
|
|
||
| To implement these modifications, a PR has been submitted to the FRR repository and is currently under review: https://github.com/FRRouting/frr/pull/14173. | ||
|
|
There was a problem hiding this comment.
These changes are not yet merged to FRR. Could you provide the targeted FRR release with protobuf change?
There was a problem hiding this comment.
As per the last SONIC Routing WG call, we have updated this HLD.
Now there is no dependency on FRR, because we are introducing a new FPM SONiC module under SONiC repo and we are moving to this module.
Could you please review the updated HLD?
| 1. Generate an FPM message containing an SRv6 SID encoded using Protobuf. | ||
| 2. Call `FpmLink::processFpmMessage()` with the generated FPM message. | ||
| 3. Verify the delivery of the FPM message to RouteSync by checking if `RouteSync.onMsgRaw()` is invoked. | ||
| 4. Ensure that the route is added to the SRV6_MY_SID_TABLE of APPL_DB. |
There was a problem hiding this comment.
Any out of sequence issue when some information of MY_SID_TABLE uses NL and other information like SRV6 SID uses Protobuf?
There was a problem hiding this comment.
Ditto. In the updated HLD, we are no longer using Protobuf. So the issue is resolved.
Signed-off-by: Carmine Scarpitta <[email protected]>
cscarpitta
changed the title
Signed-off-by: Carmine Scarpitta <[email protected]>
cscarpitta
force-pushed
the
frr-sonic-communication-channel-enhancements
branch
from
abdda4b to
69c3599
Compare
Signed-off-by: Carmine Scarpitta <[email protected]>
Signed-off-by: Carmine Scarpitta <[email protected]>
Signed-off-by: Carmine Scarpitta <[email protected]>
Signed-off-by: Carmine Scarpitta <[email protected]>
Signed-off-by: Carmine Scarpitta <[email protected]>
Many thanks for the review.
|
eddieruan-alibaba
left a comment
eddieruan-alibaba
left a comment
There was a problem hiding this comment.
This approach has been discussed in routing WG.
|
@zhangyanzhao @balajib-cisco @kperumalbfn, this HLD has been discussed and approved in the SONiC Routing WG. |
|
I could help to merge if no one has any other comments. We need this changes for Routing WG's PhoenixWing project, which upstreaming and validate SRv6 codes in 202411 release on various hardware platforms. The detail info for this project could be found at https://lists.sonicfoundation.dev/g/sonic-wg-routing/wiki/36798 |
8 participants
The document that describes the HLD is available here:
https://github.com/cscarpitta/SONiC/blob/frr-sonic-communication-channel-enhancements/doc/sonic-fpm-module/frr_sonic_communication_channel.md