Expand docker manifest capabilities to include network and ports configuration#1601
Open
azmy98 wants to merge 1 commit intosonic-net:masterfrom
Open
Expand docker manifest capabilities to include network and ports configuration#1601azmy98 wants to merge 1 commit intosonic-net:masterfrom
azmy98 wants to merge 1 commit intosonic-net:masterfrom
Conversation
azmy98
force-pushed
the
dev-docker-manifest-network-support
branch
from
85a66f0 to
22ab927
Compare
azmy98
force-pushed
the
dev-docker-manifest-network-support
branch
from
22ab927 to
c8b70fb
Compare
Contributor
|
Does this design change impact ConfigDB schema? If yes, please also include ConfigDB schema in HLD, and add yang model PR. |
Contributor
Author
|
@qiluo-msft, it does not impact ConfigDB schema |
qiluo-msft
approved these changes
Sep 16, 2024
Contributor
|
@qiluo-msft , please merge this PR, since it was approved |
Contributor
|
@qiluo-msft could you please merge this PR? It was already approved |
Contributor
|
@qiluo-msft gentle reminder to merge this PR |
1 similar comment
Contributor
|
@qiluo-msft gentle reminder to merge this PR |
Collaborator
|
PRs are not merged, move to backlog |
Contributor
Author
|
@zhangyanzhao , why move to backlog? |
Contributor
|
@zhangyanzhao HLD approved, please merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding documentation regarding the network and ports configurations for docker manifest