Support collecting module EEPROM pages in show techsupport command#1476
Merged
prgeor merged 7 commits intosonic-net:masterfrom Nov 1, 2023
Merged
Support collecting module EEPROM pages in show techsupport command#1476prgeor merged 7 commits intosonic-net:masterfrom
prgeor merged 7 commits intosonic-net:masterfrom
Conversation
Contributor
|
@Junchao-Mellanox PR in draft? |
Contributor
Author
it is mostly done, won't have major change. |
prgeor
reviewed
Sep 21, 2023
prgeor
reviewed
Sep 21, 2023
This was referenced Oct 10, 2023
prgeor
reviewed
Oct 13, 2023
Contributor
Author
|
Hi @prgeor , I have fixed all comments and updated coding PR, could you please help review the HLD as well as the coding PR? |
Contributor
|
@mihirpat1 please review |
keboliu
approved these changes
Oct 23, 2023
prgeor
reviewed
Oct 24, 2023
prgeor
reviewed
Oct 24, 2023
Contributor
Author
|
Hi @prgeor , I have replied/fixed all comments, could you please help review it? |
prgeor
approved these changes
Nov 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
SONiC show techsupport command provides the ability to collect system dump for debug purpose. Module EEPROM data is important information for PHY issue debugging, but it is not part of show techsupport command. This design will enhance show techsupport command to contain module EEPROM data.
PR