Skip to content

Sonic Netconf Server Proposal#1466

Open
aseaudi wants to merge 11 commits intosonic-net:masterfrom
aseaudi:netconf
Open

Sonic Netconf Server Proposal#1466
aseaudi wants to merge 11 commits intosonic-net:masterfrom
aseaudi:netconf

Conversation

@aseaudi
Copy link

@aseaudi aseaudi commented Sep 9, 2023

This PR is for an update in the Sonic Management Framework to add an RFC Compliant Netconf Server, which reuses the Translib and the yang models that are already part of the management framework.

The updated management framework HLD that includes the Netconf Server is under /doc/mgmt/Management Framework.md

@a-barboza
Copy link
Collaborator

I believe there is another proposal going on for NetCONF server support in SONiC:

#1428

@ebiken-ntt
Copy link
Contributor

I believe there is another proposal going on for NetCONF server support in SONiC:
#1428

Yes. We have discussed our (NTT's) NETCONF HLD #1428 in today's SONiC UMF working group meeting.
You can find the recording here: https://github.com/sonic-net/SONiC/wiki/Working-Group-and-Weekly-Meeting-Recordings-Links

We would also like @aseaudi to share this #1466 proposal to the UMF WG community. (Ritu or someone from the WG should contact you to join the WG meeting)

@zhangyanzhao
Copy link
Collaborator

BRCM registered as reviewer.
SONiC community review recording https://zoom.us/rec/share/aweG3ImuMEJXmjU3m4d5DjE3mRGV_cWzLFJtzGvfq_ZxsMAJ9KNqVPgRw45GZDgE.17WdOQVPU5MnopRz

@jeff-yin jeff-yin requested a review from kwangsuk September 28, 2023 17:46
@zhangyanzhao zhangyanzhao requested review from kwangsuk and removed request for kwangsuk September 28, 2023 17:49
@jeff-yin
Copy link

@zhangyanzhao please add @prvattem, @rathnasabapathyv, @mhampasagar, @joyas-joseph as reviewers from Dell.

@adyeung
Copy link
Collaborator

adyeung commented Sep 28, 2023

Adding @anand-kumar-subramanian @a-barboza @mbalachandar @sachinholla @faraazbrcm to review and share comments

@zhangyanzhao
Copy link
Collaborator

@zhangyanzhao please add @prvattem, @rathnasabapathyv, @mhampasagar, @joyas-joseph as reviewers from Dell.

added except mhampassagar who needs to accept the invitation to become a reviewer.

@zhangyanzhao
Copy link
Collaborator

sachinholla

invitation is sent out, will add them after accepting the invitation

@kwangsuk
Copy link

Can you please add the NETCONF server capabilities supported by the proposal?

Copy link
Contributor

@anand-kumar-subramanian anand-kumar-subramanian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more information on the Netconf server similar to the sections 3.2.2.5 gNMI server and 4.4 gNMI flow.

3. Industry-standard CLI / Cisco like CLI

* Must provide support for [OpenAPI spec](http://spec.openapis.org/oas/v3.0.3) to generate REST server side code
* Must provide support for [OpenAPI spec](http://spec.openapis.org/oas/v3.0.3) to generate REST server side code and NETCONF server side code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is OpenAPI spec going to be used to generate NETCONF server side code?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be REST only, we removed NETCONF part

@zhangyanzhao
Copy link
Collaborator

@aseaudi can you please help to add the code PRs to this HLD by referring to #806 ? Thanks.

@aseaudi
Copy link
Author

aseaudi commented Oct 13, 2023

@kwangsuk

Can you please add the NETCONF server capabilities supported by the proposal?

Done

@aseaudi
Copy link
Author

aseaudi commented Oct 13, 2023

resolves #1498

@zhangyanzhao
Copy link
Collaborator

@aseaudi can you please help to add the code PRs by referring to #806 ? Thanks.

@zhangyanzhao
Copy link
Collaborator

code PR is not ready, move to backlog for future release

@hussamsh
Copy link

Hello @zhangyanzhao ,

The code PR is ready here, can you please move forward with this HLD PR and the code PR for 202511 release ?

I also sent an email to Anil regarding the same request.


###### 3.2.2.11.14 API Documentation

NETCONF server will provide all schemas, check section 3.2.2.11.8.3.
Copy link

@chenkelly chenkelly Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We couldn’t find this section 3.2.2.11.8.3. Could you kindly confirm if it’s missing or located elsewhere?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenkelly corrected the section number

25. Write lock acquired in Step 3 is released.
26. Final response is returned from the Translib infra to REST/GNMI.

### 4.3 NETCONF <get> flow
Copy link

@chenkelly chenkelly Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section should be 4.6. A flow diagram might also be helpful to illustrate these steps more clearly.
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenkelly section updated to 4.6

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.


###### 3.2.2.11.5 Concurrency

REST server will accept concurrent requests. Translib provides appropriate locking mechanism - parallel reads and sequential writes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"REST Server" looks like a typo for "NETCONF server".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is corrected now

* TACACS authenticaation.
* No authentication

Details are in [SONiC RBAC HLD](https://github.com/project-arlo/SONiC/blob/master/doc/aaa/SONiC%20RBAC%20HLD.md).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link for the reference document on "SONiC RBAC HLD" appears to be obsolete.
I assume the following document is the one the link points to.
Is my guess correct?
https://github.com/project-arlo/SONiC/blob/dell_sonic_share/doc/mgmt/SONiC_HAMD_RBAC_HLD.md

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is now updated , thanks

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.


NETCONF server will Support Netconf 1.1.

###### 3.2.2.11.8 NETCONF Discovery

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no sections were skipped, the section number is 3.2.2.11.7 instead of 3.2.2.11.8.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sugisono-omw it is corrected now, thanks


The NETCONF server will reply back with error in several situations, to be defined ...

###### 3.2.2.4.13 DB Schema

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"3.2.2.4.13" seems to be a typo for "3.2.2.11.13".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sugisono-omw it is corrected now, thanks

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: DeferredForNextRelease
Status: MovedToBacklog

Development

Successfully merging this pull request may close these issues.