Conversation
|
community review recording https://zoom.us/rec/share/fhMIOkkDYx3INSShyKdXw9dXl8HqhBqQLxzG1mEUyvJrxdYbdGhofRS9Xs4MCh2g.aBeFosVoWBv3VBXi |
doc/mgmt/gnmi/save_on_set.md
Outdated
| #### Unit Test cases | ||
|
|
||
| - No behavior change if the feature is not enabled. | ||
| - A gNMI.Set() call should generate a signal to save ConfigDB. |
There was a problem hiding this comment.
Looks like we invoke "write memory" click call for every gNMI set operation when the save-on-set is enabled, not sure signalling is the word usage, please fix it.
doc/mgmt/gnmi/save_on_set.md
Outdated
| ##### Telemetry Executable | ||
| A new command-line parameter will be added to control the behavior of the save-on-set functionality. By default, i.e. when the option is not specified, the gNMI server will behave as it did before this change - the configuration will not be saved to a file without explicit action from the administrator for example by execution of a command via ssh connection. | ||
|
|
||
| The new parameter will be: --with-save-on-set and when present it will configure a function pointer variable gnmi.SaveOnSet to point to a function that actually performs the save operation. |
There was a problem hiding this comment.
Are we getting this feature enable/disable from config_db field?
There was a problem hiding this comment.
Added clarification that the startup script will read from the DB to pass the value along to the command line argument on startup.
rlucus
dismissed stale reviews from anand-kumar-subramanian and tomek-US
via
9e06354
|
code PR is missed and can you please add @rlucus ? |
|
code PR is not ready, move to backlog for future release |
* add support for save-on-set to gnmi sonic-net/SONiC#1297 * leave default if not set * move to telemetry.sh
bhagatgit
requested review from
bhagatgit and
qiluo-msft
and removed request for
qiluo-msft
|
Could you add the code PRs in a markdown table in this HLD PR's description? |
Pull Requests |
* add support for save-on-set to gnmi sonic-net/SONiC#1297 * leave default if not set * move to telemetry.sh
|
Approving/merging this HLD as the code PRs are already submitted. |
10 participants
Pull Requests