Skip to content

Resource Monitoring support for Generic SAI Extensions#1243

Merged
prsunny merged 4 commits intosonic-net:masterfrom
svshah-intel:master
Jun 6, 2023
Merged

Resource Monitoring support for Generic SAI Extensions#1243
prsunny merged 4 commits intosonic-net:masterfrom
svshah-intel:master

Conversation

@svshah-intel
Copy link
Copy Markdown
Contributor

@svshah-intel svshah-intel commented Jan 31, 2023 •
edited
Loading

Why I did it
HLD describing Critical Resource Monitoring (CRM) support for Generic SAI Extensions

Repo PR title State
sonic-swss resource monitoring support for generic SAI extension tables #2649 GitHub issue/pull request detail

@zhangyanzhao
Copy link
Copy Markdown
Collaborator

zhangyanzhao commented Jan 31, 2023 •
edited
Loading

reviewed in community. Please leave your github id if you want to be reviewer of this feature.

madhupalu
madhupalu reviewed Jan 31, 2023
View reviewed changes
@svshah-intel svshah-intel mentioned this pull request Feb 1, 2023
Merged
@svshah-intel
Copy link
Copy Markdown
Contributor Author

svshah-intel commented Feb 9, 2023

@madhupalu could you please approve if looks good

madhupalu
madhupalu approved these changes Feb 9, 2023
View reviewed changes
@prsunny prsunny requested a review from volodymyrsamotiy March 1, 2023 17:04
@svshah-intel
Copy link
Copy Markdown
Contributor Author

svshah-intel commented May 2, 2023

@volodymyrsamotiy can you please review the HLD

@reshmaintel
Copy link
Copy Markdown

reshmaintel commented May 2, 2023

@prsunny @volodymyrsamotiy Could you please complete this review for 202305. Thank you!

@prsunny prsunny requested a review from oleksandrivantsiv May 2, 2023 20:25
@reshmaintel
Copy link
Copy Markdown

reshmaintel commented May 12, 2023

@zhangyanzhao @prsunny Could you please merge this PR, as Madhu has approved it. Thanks.

@oleksandrivantsiv
Copy link
Copy Markdown
Contributor

oleksandrivantsiv commented May 16, 2023

Does this feature require CLI implementation? How the user should get the information from the DB?

@reshmaintel
Copy link
Copy Markdown

reshmaintel commented May 18, 2023

Does this feature require CLI implementation? How the user should get the information from the DB?

This feature does not require CLI, and user can access via regular DB lookup commands

@svshah-intel
Copy link
Copy Markdown
Contributor Author

svshah-intel commented May 19, 2023 •
edited
Loading

@oleksandrivantsiv As Reshma responded, this feature was developed to be consumed by PINS deployment. There are no CLIs required. The info will be read from the DB.
Do you have other review comments? Can this be approved and merged?

@prsunny prsunny merged commit 2692a47 into sonic-net:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prsunny prsunny prsunny approved these changes

@madhupalu madhupalu madhupalu approved these changes

@volodymyrsamotiy volodymyrsamotiy Awaiting requested review from volodymyrsamotiy

@oleksandrivantsiv oleksandrivantsiv Awaiting requested review from oleksandrivantsiv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@svshah-intel @zhangyanzhao @reshmaintel @oleksandrivantsiv @prsunny @madhupalu