Update dhcpv6 options and performance#1109
Update dhcpv6 options and performance#1109kellyyeh wants to merge 3 commits intosonic-net:masterfrom
Conversation
| ``` | ||
| Restart dhcp_relay after updating ipv6 helper information. | ||
|
|
||
| **only DHCP_RELAY table needs to be updated for the latest versions. |
There was a problem hiding this comment.
Can you please specify what do you mean by latest version?
|
|
||
| Usage: | ||
| ``` | ||
| redis-cli -n 4 hset DHCP_RELAY|<vlan> dhcpv6_option|rfc6939_support <true/false> |
There was a problem hiding this comment.
Using redis-cli is not a standard way of configuring SONiC. It should be done through config load of json when click CLI is not available. Please update the documentation to have all configuration examples using json format and mention it can be used with config load command.
There was a problem hiding this comment.
Please add a json example of the config to be put it.
Eg:
{
"DHCP_RELAY" :{
"Vlan100" : {
"dhcpv6_servers" : ["fc02:2000::2"]
}
}
}
There was a problem hiding this comment.
This comment is still applicable
|
|
||
| Usage: | ||
| ``` | ||
| redis-cli -n 4 hset DHCP_RELAY|<vlan> dhcpv6_option|rfc6939_support <true/false> |
There was a problem hiding this comment.
Please add a json example of the config to be put it.
Eg:
{
"DHCP_RELAY" :{
"Vlan100" : {
"dhcpv6_servers" : ["fc02:2000::2"]
}
}
}
| # Config Update | ||
|
|
||
| We have shifted from VLAN table to DHCP_RELAY table to store ipv6 helper information. | ||
| Only DHCP_RELAY table needs to be updated for the versions containing PR https://github.com/sonic-net/sonic-buildimage/pull/10654, or version 20201231.75 and 20181130.98 and above |
There was a problem hiding this comment.
Can you also include this PR sonic-net/sonic-buildimage#13006 and those versions might not work completely as suggested in the description of the PR
| type bool; | ||
| } | ||
|
|
||
| leaf dhcpv6_option|interface_id { |
There was a problem hiding this comment.
I don't see this in the yang model. Is this a future change? https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-dhcpv6-relay.yang
There was a problem hiding this comment.
Yes will be a future change
|
|
||
| Usage: | ||
| ``` | ||
| redis-cli -n 4 hset DHCP_RELAY|<vlan> dhcpv6_option|rfc6939_support <true/false> |
There was a problem hiding this comment.
This comment is still applicable
| Typical number of vlans used with dhcp6relay is around 2 vlans. Performance degration and high CPU utilization is seen on devices with more than 25 vlans configured, especially devices with weaker CPU's. | ||
| Tests have shown functionality and performance degradation when there are more than 20 vlans configured on weaker CPU's. | ||
|
|
||
| • 25 Vlans - Passed on SPC1. |
There was a problem hiding this comment.
Please remove Vendor specific information like SPC1.
Add interface-id option, update yang model, config update
Update performance with typical vlan usage