saithrift client & server integration with DASH bmv2 (Fix #131,158)#164
Merged
KrisNey-MSFT merged 148 commits intosonic-net:mainfrom Aug 2, 2022
Merged
saithrift client & server integration with DASH bmv2 (Fix #131,158)#164KrisNey-MSFT merged 148 commits intosonic-net:mainfrom
KrisNey-MSFT merged 148 commits intosonic-net:mainfrom
Conversation
…to merge eventually. Meanwhile can locally modify SAI makefiles.
…n dist tarball to /usr/lib inside container so can be extracted for deployment to a host.
…ss_spec, comments.
…brary image and selectively copying to BMV2 builder/runtime image based on available p4lang docker image.
…s; runtime client is always built locally, not pulled. Change python requirements to hardlink to DASH/test/requirements.txt. Change DOckerfile name for consistency.
…il less often, suspect CI runner limits are being strained. Tests fail sometimes w/o reason.
…Quick-start instructions.
…ets() to verify_packet() to avoid failing due to junk entering veths from host network.
chrispsommers
changed the title
chrispsommers
changed the title
…pcgen, wasn't needed after all.
chrispsommers
changed the title
mukeshmv
reviewed
Aug 2, 2022
|
|
||
| vip.apply(); | ||
| // TODO [cs] shouldn't this also be called at end of ingress? | ||
| // Shouldn't it call mark_to_drop(standard_metadata); |
Collaborator
|
It has been open a week for review;there have been no comprehensive reviews and we do not expect more. There have been several "testers" and some valuable feedback and consequent fixes along the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131, #158:
Support P4 remove operations. Improve P4RT logging in libsai.
Autogenerate saithrift-server daemon and saithrift-client docker with all tools and scripts.
Pytest & PTF Framework integration.
Exemplar PTF and Pytest test-cases.
CI enhancements for all of the above.
Documentation.