Closed
Conversation
…test for error code was backwards and log message used same write updateType string for all operations. I fixed the compare and used a dynamic enum print method.
…sg. THe test for error code was backwards and log message used same write updateType string for all operations. I fixed the compare and used a dynamic enum print method." This reverts commit 820e08e.
…test for error code was backwards and log message used same write updateType string for all operations. I fixed the compare and used a dynamic enum print method.
Collaborator
|
Can we add the exact description of the fix instead of issue #? It's impossible to track in git. |
Collaborator
Author
@marian-pritsak Sorry, the commit message didn't display. Please see revised description. |
Collaborator
Author
|
Fixed in #181, no need for this PR any more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #158 - libsai delete operation failure and log msg. The test for error code was backwards and log message used same write updateType string for all operations. I fixed the compare and used a dynamic enum print method.