Replace CRLF with LF on release files

[gschizas]

This resolves NEXUS-21834 which prevents APT repositories from working when running under Windows

[aornatovskyy]

Hi @gschizas !
First of all, thank you for your contribution, for spending time on issue investigation and providing a solution.
Looks like there is a problem with the generation metadata stage and it is better to fix the issue on that stage instead of afterward.

Can you please attach the example of a corrupted file to the ticket?

Regards,
Anatoliy

[gschizas]

The problem seems to be mostly in the PGP signing.
Here's a sample response I made with mitmproxy. And here's the
full mitmproxy file (whatever that means).

You'll see that some lines end with CR+LF (lines 1-3 and 17-28) and some with just LF (lines 3-16)

[maxhermann]

Hi there,

i guess that i run into the same issue here. May i ask when the fix will be merged @aornatovskyy ?

Im using Nexus Repository for a Yocto Linux and got problems with the lineendings like gschizas.
Seems like this Yocto can't handle the mixed CRLF LF endings that well.

Regards,
Max

[mynewzone]

t

[gschizas]

I managed to do a workaround, using URL rewrite.

Add this to web.config:

<?xml version="1.0" encoding="UTF-8"?>
<configuration>
    <system.webServer>
        <rewrite>
            <outboundRules>
                <rule name="Replace CRLF with LF" preCondition="ReleaseFile">
                    <match filterByTags="None" pattern="\r" />
                    <action type="Rewrite" value="" />
                </rule>
                <preConditions>
                    <preCondition name="ReleaseFile">
                        <add input="{REQUEST_URI}" pattern="/repository/([-a-z0-9]*)/dists/(\w*)/InRelease" />
                    </preCondition>
                </preConditions>
            </outboundRules>
        </rewrite>
    </system.webServer>
</configuration>

And then it just works!

The REQUEST_URI does most of the heavy lifting. It should work for most cases, but if it doesn't, it's easy to extend the regular expression, or even hardcode the URL for the repo.

This is still just a workaround, but it's one that works without any changes to the code.

[maxhermann]

Thanks for your solution.

After I had read your post I came up with another idea.

We routed the ../InRelease file for all our apt-repositories to a 404 error page. This way the "apt-get update" command results in using the normal "release" file instead of the corrupted "InRelease" that is produced by the repo. Now apt-get update works again.

That could be a cleaner workaround instead of modifying the file itself.