Skip to content

Conversation

@ganesh-nithin
Copy link
Contributor

@ganesh-nithin ganesh-nithin commented Oct 20, 2024

Why this change is required

Currently the start date range is calculated based on today's date. It's restricting users to get old data, so this PR aims to change the start date range calculation based on the end date.

Describe your changes

  • Changed the start date range calculation from today's date to end date.

How this change has been tested

Tested by loading previous months data.

  • User can select at most 190 days date range of data at any in the start & end date interval.

Reference

image

Checklist

  • I have performed a self review of my code and intend to submit as such
  • I have added necessary explanations and inline comments for review
  • I have considered updating necessary README or other documentations
  • I have added/modified necessary automated tests
  • This includes a breaking changes and needs to be listed in release notes

@ganesh-nithin
Copy link
Contributor Author

Client CI is blocked by 3 low severity vulnerabilities (GHSA-pxg6-pf52-xh8x) occurred in devDependency MSW (https://github.com/mswjs/msw). They have an active PR to mitigate the issue mswjs/msw#2312.

Signed-off-by: Ganesh Nithin <[email protected]>
Signed-off-by: Ganesh Nithin <[email protected]>
@ganesh-nithin ganesh-nithin merged commit 253a346 into main Nov 13, 2024
6 checks passed
@ganesh-nithin ganesh-nithin deleted the users/nithin-sarvabhotla/feat-date-range-fix branch November 13, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants