Skip to content

feat:encode sfn > functionId & extractedFilename #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 1.x
Choose a base branch
from
Open

feat:encode sfn > functionId & extractedFilename #1872

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d7c38e7
feat:encode sfn > functionId & extractedFilename
thinke5 Mar 27, 2025
0d3ca23
feat:hash encode sfn > functionId
thinke5 Mar 28, 2025
73b7c1b
feat:only encode sfn > extractedFilename
thinke5 Apr 2, 2025
4042f70
fix:not change server-handler.ts
thinke5 Apr 2, 2025
b640817
fix:not change server-handler.ts
thinke5 Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions packages/start/config/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,14 @@ function solidStartServerFsRouter(config) {
);
}

/**
* @param {string} filepath
* @returns {string}
*/
function convertToRelativePath(filepath) {
return filepath.replace(process.cwd(), "~");
}

const SolidStartServerFnsPlugin = createTanStackServerFnPlugin({
// This is the ID that will be available to look up and import
// our server function manifest and resolve its module
Expand All @@ -47,23 +55,23 @@ const SolidStartServerFnsPlugin = createTanStackServerFnPlugin({
fileURLToPath(new URL("../dist/runtime/server-runtime.js", import.meta.url))
)}"`,
replacer: opts =>
`createServerReference(${() => {}}, '${opts.functionId}', '${opts.extractedFilename}')`
`createServerReference(${() => {}}, '${opts.functionId}', '${encodeURIComponent(convertToRelativePath(opts.extractedFilename))}')`
},
ssr: {
getRuntimeCode: () =>
`import { createServerReference } from '${normalize(
fileURLToPath(new URL("../dist/runtime/server-fns-runtime.js", import.meta.url))
)}'`,
replacer: opts =>
`createServerReference(${opts.fn}, '${opts.functionId}', '${opts.extractedFilename}')`
`createServerReference(${opts.fn}, '${opts.functionId}', '${encodeURIComponent(convertToRelativePath(opts.extractedFilename))}')`
},
server: {
getRuntimeCode: () =>
`import { createServerReference } from '${normalize(
fileURLToPath(new URL("../dist/runtime/server-fns-runtime.js", import.meta.url))
)}'`,
replacer: opts =>
`createServerReference(${opts.fn}, '${opts.functionId}', '${opts.extractedFilename}')`
`createServerReference(${opts.fn}, '${opts.functionId}', '${encodeURIComponent(convertToRelativePath(opts.extractedFilename))}')`
}
});

Expand Down