-
Notifications
You must be signed in to change notification settings - Fork 401
Closed as not planned
Labels
bugSomething isn't workingSomething isn't working
Description
Originally titled "Remove 6 un-necessary package.json dependencies for new projects"
Duplicates
- I have searched the existing issues
Latest version
- I have tested the latest version
Current behavior 😯
FYI: Search "remove un-necessary deps vite esbuild" gave no results.
npm init solid@latest includes several deps that aren't needed for npm run dev/build/start
Expected behavior 🤔
New projects' package.json files only include necessary deps
Steps to reproduce 🕹
Steps:
npm init solid@latest- Remove these: esbuild, postcss, solid-js, @solidjs/router, @solidjs/meta, vite
- Run
npm i - Run
npm run dev/build/start - Observe everything works without these deps.
Context 🔦
New projects (with SSR and typescript) could have a package.json file like this:
"start": "solid-start start"
},
"type": "module",
+ "optionalDependencies:comment": [
+ "esbuild uses `optionalDependencies` to install platform-specific binaries.",
+ "Using `npm install --omit=optional` will cause issues with esbuild."
+ ],
"devDependencies": {
"@types/node": "^18.16.19",
- "esbuild": "^0.14.54",
- "postcss": "^8.4.26",
"solid-start-node": "^0.3.0",
- "typescript": "^4.9.5",
- "vite": "^4.4.6"
+ "typescript": "^4.9.5"
},
+ "deps:comment": [
+ "These are needed for `npm run start` in production."
+ ],
"dependencies": {
- "@solidjs/meta": "^0.28.5",
- "@solidjs/router": "^0.8.2",
- "solid-js": "^1.7.9",
"solid-start": "^0.3.1"
},
"engines": {Your environment 🌎
what command?Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working