Fixed #56

.changeset/funny-showers-hope.md

@@ -0,0 +1,5 @@
+---
+"@solidjs/meta": patch
+---
+
+fix: Don't read props of the Title component during cleanup

src/index.tsx

@@ -41,8 +41,9 @@ const metaTagProperties: string[] =
 const getTagKey = (tag: TagDescription, properties: string[]) => {
   // pick allowed properties and sort them
   const tagProps = Object.fromEntries(
-    Object.entries(tag.props)
-      .filter(([k]) => properties.includes(k))
+    properties
+      .filter(k => k in tag.props)
+      .map(k => [k, tag.props[k]])
       .sort()
   );
 

test/index.spec.tsx

@@ -1,5 +1,5 @@
 /* @jsxImportSource solid-js */
-import { createSignal, lazy } from "solid-js";
+import { createSignal, getOwner, lazy } from "solid-js";
 import { hydrate, render, Show } from "solid-js/web";
 import { MetaProvider, Title, Style, Meta, Link, Base } from "../src";
 import { hydrationScript, removeScript } from "./hydration_script";
@@ -304,6 +304,30 @@ test("throws error if head tag is rendered without MetaProvider", () => {
   }).toThrowError(/<MetaProvider \/> should be in the tree/);
 });
 
+test("doesn't create any effect on removal", () => {
+  let div = document.createElement("div");
+
+  const [ show, setShow ] = createSignal(true);
+  const showAndTest = () => {
+    expect(getOwner()?.owner).toBeTruthy();
+    return show();
+  };
+
+  const dispose = render(
+    () => (
+      <MetaProvider>
+        <Show when={show()}>
+          <Title>Something {showAndTest()} that forces the Solid compiler to create a memo here</Title>
+        </Show>
+      </MetaProvider>
+    ),
+    div
+  );
+
+  setShow(false);
+  dispose();
+});
+
 test("Escaping the title tag", () => {
   let div = document.createElement("div");
   const snapshot = '<title>Hello&lt;/title&gt;&lt;script&gt;alert("inject");&lt;/script&gt;&lt;title&gt; World</title>';