Skip to content

Intercropping: Multiple Accessions per Plot#5949

Open
dwaring87 wants to merge 49 commits intomasterfrom
topic/intercropping_multiple_accessions_per_plot
Open

Intercropping: Multiple Accessions per Plot#5949
dwaring87 wants to merge 49 commits intomasterfrom
topic/intercropping_multiple_accessions_per_plot

Conversation

@dwaring87
Copy link
Member

Description

This adds intercropping support by allowing multiple accessions to be associated with a single plot

Basically, this allows additional Accessions to be linked to plots using a new intercrop_plot_of stock relationship type in addition to the usual 1:1 link with the plot_of relationship type. The changes allow for any number of intercrop_plot_of stock relationships to be made while maintaining the assumption that only one plot_of relationship exists.

DB Patches:

  • adds an intercrop_plot_of stock relationship type
  • updates the materialized_phenoview matview to include intercrop accessions (DB Patch Diff) - this uses the newer/correct traits matview definition from fix the traits view again. #5910
  • updates the materialized_phenotype_jsonb_table matview to include intercrop accessions (DB Patch Diff)

Changes:

  • Trial Upload: adds an optional column of intercrop_accession_name which allows additional Accessions to be associated with a plot. This can be a comma-separated list or the column can be included more than once to allow for more than one intercropped accessions.
  • Data Download: adds intercropGermplasmDbId and intercropGermplasmName columns that include the ID and name of the intercropped accessions (comma-separated if more than one)
  • Trial Detail Page:
    • updated table of Accessions (includes Species column)
    • updated table of Plots (includes all Accessions in Plot)
      • also updated to include plot number and all Accession synonyms (instead of just one)
    • updated field layout to include all Accessions
      • in the tool-tip when hovering over a plot on the visual layout
      • included in the layout download file
  • Search Wizard: all Accessions are included when you select a Trial or Plot

Future Work:

  • Add Tests
  • Update Manual
  • Add support to Trial Design tool?
  • Handle Subplots (should the Accessions associated with subplots be all of the Accessions or a specific one?)
  • Handle Plants (the user would need to specify which Accession the plant is)

Fixes #5308, Fixes #4690

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

Add intercrop_accession_name column to add intercropped accessions to plots
Associate intercropped accessions with plots using the 'intercrop_plot_of' stock relationship
Add option to include intercrop stock columns in phenotype data downloads from the trial detail page and search wizard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intercropping: Support multiple accessions per plot Intercropping support in trials

1 participant