This repository was archived by the owner on Mar 11, 2025. It is now read-only.
remove solana-program from spl-type-length-value#7428
Merged
Conversation
kevinheavey
commented
Oct 31, 2024
|
|
||
| // Export current sdk types for downstream users building with a different sdk | ||
| // version | ||
| pub use solana_program; |
Contributor
Author
There was a problem hiding this comment.
breaking change
kevinheavey
commented
Oct 31, 2024
| fn unpack_from_slice(src: &[u8]) -> Result<Self, spl_type_length_value::solana_program::program_error::ProgramError> { | ||
| solana_program::borsh1::try_from_slice_unchecked(src).map_err(Into::into) | ||
| fn unpack_from_slice(src: &[u8]) -> Result<Self, spl_type_length_value::solana_program_error::ProgramError> { | ||
| solana_borsh::v1::try_from_slice_unchecked(src).map_err(Into::into) |
Contributor
Author
There was a problem hiding this comment.
breaking change
joncinque
approved these changes
Oct 31, 2024
joncinque
left a comment
joncinque
left a comment
Contributor
There was a problem hiding this comment.
Looks great, thanks! Seems like CI error is spurious
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated some imports and replaced spl-program-error with inlining
Breaking changes:
solana_programwith re-exports of the smaller cratessolana_programin SplBorshVariableLenPackBuilder