This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Revert ESLint plugin bump#7260
Merged
Merged
Conversation
joncinque
approved these changes
Sep 12, 2024
joncinque
left a comment
joncinque
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this up! I didn't realize we were using different versions between the overall JS job and the per-program JS job
Contributor
Author
Do you want to be using different versions? I think it makes sense to actually matrix 16 and up for at least the JS PRs maybe? This way, any time a JS lib is changed (including dependabot) we get the whole compatibility run-through. |
Contributor
|
Yeah sure, it couldn't hurt to do 16, 18, and 20. Edit: and maybe 22 while we're at it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The latest ESLint plugin bump from dependabot broke CI for JavaScript jobs.
Summary of Changes
Revert it.
Closes #7259