This repository was archived by the owner on Mar 11, 2025. It is now read-only.
token-cli: Split out CI into separate step, run tests in serial #3425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
approved these changes
Aug 3, 2022
Contributor
CriesofCarrots
left a comment
CriesofCarrots
left a comment
There was a problem hiding this comment.
lgtm! We can readdress if the time to complete ends up feeling too painful
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The token-cli tests keep failing CI.
Solution
Serialize all the tests. This takes a lot longer, so also split off the tests into a separate CI step.