feat: Implement array and vector argument inputs#791
Merged
Woody4618 merged 11 commits intosolana-foundation:masterfrom Dec 29, 2025
Merged
Conversation
|
@askov is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Generated with ❤️ by ellipsis.dev |
Contributor
|
Depends on #790 |
rogaldh
force-pushed
the
development-feat-support-idl-array-inputs
branch
from
edddd6e to
7bfb766
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
It's better to merge this after #797 |
Woody4618
approved these changes
Dec 22, 2025
Woody4618
approved these changes
Dec 22, 2025
| return /vec\(/.test(arg.type); | ||
| } | ||
|
|
||
| export function getArrayMaxLength(arg: ArgField): number | undefined { |
Collaborator
There was a problem hiding this comment.
Is there not better way to do this?
Contributor
There was a problem hiding this comment.
I've found a way to use the rawType. Works better than regexps
Woody4618
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented vector/array arg inputs for IDL forms.
This PR depends on #779, so there is actually only one commit. Should be rebased as soon as the base PR is merged
Type of change
Screenshots
screen-capture.2.webm
Testing
initializePollWithCandidates(vector example) orinitializePollWithTwoCandidates(array example) and experiment with inputsRelated Issues
N/A
Checklist