Skip to content

lang: Add checked operations for lamport management#2563

Closed
0xC0A1 wants to merge 1 commit intosolana-foundation:masterfrom
0xC0A1:lamports-trait-checked
Closed

lang: Add checked operations for lamport management#2563
0xC0A1 wants to merge 1 commit intosolana-foundation:masterfrom
0xC0A1:lamports-trait-checked

Conversation

@0xC0A1
Copy link
Contributor

@0xC0A1 0xC0A1 commented Jul 9, 2023

References: #2552

This PR adds checked operations for lamport management in order to avoid Numeric Overflow exploits.

Pending:

  • Add tests for failing scenarios (A numeric overflow is triggered u64 variant).

@vercel
Copy link

vercel bot commented Jul 9, 2023

@kevinrodriguez-io is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@0xC0A1
Copy link
Contributor Author

0xC0A1 commented Jul 12, 2023

@acheroncrypto can you throw a quick review on this?

@acheroncrypto
Copy link
Collaborator

This PR adds checked operations for lamport management in order to avoid Numeric Overflow exploits.

Are you able to exploit this?

@0xC0A1
Copy link
Contributor Author

0xC0A1 commented Jul 12, 2023

Will add tests, I'm a bit unfamiliar with running all the anchor toolchain but I'll attempt to trigger an exploit with a test later

@0xC0A1 0xC0A1 closed this by deleting the head repository Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants