lang: Add checked operations for lamport management#2563
Closed
0xC0A1 wants to merge 1 commit intosolana-foundation:masterfrom
0xC0A1:lamports-trait-checked
Closed
lang: Add checked operations for lamport management#25630xC0A1 wants to merge 1 commit intosolana-foundation:masterfrom 0xC0A1:lamports-trait-checked
0xC0A1 wants to merge 1 commit intosolana-foundation:masterfrom
0xC0A1:lamports-trait-checked
Conversation
|
@kevinrodriguez-io is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@acheroncrypto can you throw a quick review on this? |
Collaborator
Are you able to exploit this? |
Contributor
Author
|
Will add tests, I'm a bit unfamiliar with running all the anchor toolchain but I'll attempt to trigger an exploit with a test later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References: #2552
This PR adds checked operations for lamport management in order to avoid Numeric Overflow exploits.
Pending:
u64variant).