Respect absent logs on simulation

[rogaldh]

I'd consider using the safe operator to cover absent logs cases.

Having such a response will fail the method execution:

{
  jsonrpc: '2.0',
  error: {
    code: -32003,
    message: 'Transaction signature verification failure',
    data: undefined
  },
  id: 'e23c1fad-e3ca-47bf-ad0f-11a5bd4b49c2'
}

[vercel]

@rogaldh is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

[acheroncrypto]

It wouldn't hurt to merge this but is data ever undefined?

[rogaldh]

It's the case when we receive a response without a data field; 32003, for ex.
https://github.com/coral-xyz/anchor/blob/ceb220bf99dbb5cdc4ec72b50c1e716e8b91273a/ts/packages/anchor/src/utils/rpc.ts#L193-L194

data will appear after applying SimulatedTransactionResponseStruct on the unsafeRes.

Actually, the response (unsafeRes) causing troubles looks like that.

{
  jsonrpc: '2.0',
  error: {
    code: -32003,
    message: 'Transaction signature verification failure'
  },
  id: '1'
}

I assume that affects any error with just the code and message properties.

[acheroncrypto]

It's the case when we receive a response without a data field; 32003, for ex.

https://github.com/coral-xyz/anchor/blob/ceb220bf99dbb5cdc4ec72b50c1e716e8b91273a/ts/packages/anchor/src/utils/rpc.ts#L193-L194

data will appear after applying SimulatedTransactionResponseStruct on the unsafeRes.

Actually, the response (unsafeRes) causing troubles looks like that.

{
  jsonrpc: '2.0',
  error: {
    code: -32003,
    message: 'Transaction signature verification failure'
  },
  id: '1'
}

I assume that affects any error with just the code and message properties.

Yes, thank you but that case is already handled:

https://github.com/coral-xyz/anchor/blob/b8eda6980c895d709b2859ef456e0bc83675f903/ts/packages/anchor/src/utils/rpc.ts#L197

The check will only pass if data property exists.

[rogaldh]

It exists, tbh.
create adds the key to the object, like I've said before:

{
  res: {
    jsonrpc: '2.0',
    error: {
      code: -32003,
      message: 'Transaction signature verification failure',
      data: undefined
    },
    id: '94192407-d2ca-470f-8f22-a7fa0c9121fc'
  }
}

UPD: I'm talking about cjs target.

[acheroncrypto]

Thanks, this wouldn't hurt in any case. CI is failing(not due to your changes) because it's outdated, could you update this branch to master?