Support custom instruction discriminators#2349
Support custom instruction discriminators#2349guibescos wants to merge 4 commits intosolana-foundation:masterfrom
Conversation
|
@guibescos is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for the PR! Would it be possible to give a bit more explanation about what this is for and the changes it makes? As far as I'm aware the anchor idl currently has no support at all for including the discriminator hash in the IDL? Adding support for discriminators more generally is a thing that has been floated, though no steps have been taken yet on making it a reality, e.g. #2138 . I suspect that adding support for discriminators is much broader problem than the solution here which might only tackle a very niche aspect of that? But totally open to understanding what the goal is here. Also, would this be a breaking or non-breaking change to the IDL or programs that currently know how to parse IDLs? |
|
This is a draft and it was made to tackle Pyth's oracle program that I'm working on. |
|
Cool, no worries if it's only a draft. Just trying to stay on top of open PRs. We could definitely look at merging a custom coder for pyth like has been done with the SPL ones by acheron. |
|
Added in #2824. |
No description provided.