Skip to content

Add support for idl enum tuples, enchance types#2185

Merged
armaniferrante merged 6 commits intosolana-foundation:masterfrom
devDesu:ts-types-enchantments
Oct 18, 2022
Merged

Add support for idl enum tuples, enchance types#2185
armaniferrante merged 6 commits intosolana-foundation:masterfrom
devDesu:ts-types-enchantments

Conversation

@devDesu
Copy link
Contributor

@devDesu devDesu commented Sep 15, 2022

  • Recursive types decoding
  • Correct enum types decoding
  • IdlEvents type

- Recursive types decoding
- Correct enum types decoding
- IdlEvents type
@vercel
Copy link

vercel bot commented Sep 15, 2022

Someone is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@devDesu devDesu force-pushed the ts-types-enchantments branch from 71aa371 to 9077d29 Compare September 15, 2022 14:23
@devDesu
Copy link
Contributor Author

devDesu commented Sep 15, 2022

@armaniferrante please take a look at the PR

@devDesu
Copy link
Contributor Author

devDesu commented Sep 15, 2022

Resolves issue #2050

@devDesu
Copy link
Contributor Author

devDesu commented Sep 23, 2022

Ping @armaniferrante

@skulltech
Copy link

This would be very useful!! +1

@dnut
Copy link
Contributor

dnut commented Sep 27, 2022

We're stuck with 0.24.2 because of a regression in 0.25.0 that this should resolve. Would be nice to see this merged.

@ngundotra
Copy link
Contributor

ngundotra commented Sep 29, 2022

This is very helpful! This would also make the spl_governance Anchor IDL work (which depends on enum variants with tuple data)

@italoacasas @armaniferrante

@devDesu
Copy link
Contributor Author

devDesu commented Oct 10, 2022

@Henry-E
Copy link
Collaborator

Henry-E commented Oct 10, 2022 via email

@devDesu
Copy link
Contributor Author

devDesu commented Oct 18, 2022

ping @Henry-E @stegaBOB @ChewingGlass

@armaniferrante armaniferrante merged commit 8e66d5b into solana-foundation:master Oct 18, 2022
@armaniferrante
Copy link
Contributor

armaniferrante commented Oct 18, 2022

Thanks @devDesu for your persistence!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants