Validate empty string attributes #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 22, 2020 16:02
* Value can't be empty * DataType can't be empty Adding validation for message body: * Message body can't be empty
adamw
reviewed
Oct 23, 2020
| def verifyMessageStringAttribute(stringAttribute: String, limits: Limits): Either[String, Unit] = | ||
| def verifyMessageStringAttribute( | ||
| attributeValue: String, | ||
| attributeName: String, |
Member
There was a problem hiding this comment.
shouldn't it be name-value, as that's the usual order? :)
Contributor
Author
There was a problem hiding this comment.
Yeah, I have changed it to name-value order :)
adamw
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #373
According to doc, message attribute value/data type can't be an empty String. Same applies to message body