Add tracing handling #405
Merged
Add tracing handling #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 19, 2020 15:42
* Retrieve message should not return empty string if trace ID is empty * SendMessageBatch should retrieve trace ID from request headers * Overall code improvements * Tests for tracing handling
* Removing unused code * Renaming test names
adamw
reviewed
Oct 21, 2020
|
|
||
| import scala.collection.JavaConverters.{iterableAsScalaIterableConverter, mapAsScalaMapConverter, seqAsJavaListConverter} | ||
|
|
||
| class TracingTests extends SqsClientServerCommunication with Matchers with OptionValues { |
Member
There was a problem hiding this comment.
👍 good idea to finally split this monster class with tests
adamw
reviewed
Oct 21, 2020
| } | ||
|
|
||
| private def extractAwsXRayTracingHeader(request: HttpRequest): Map[String, String] = { | ||
| request.headers.find(_.name() == "X-Amzn-Trace-Id").map(header => header.name() -> header.value()).toMap |
Member
There was a problem hiding this comment.
I think this should be .equalsIgnoreCase as headers are case-insensitive
adamw
reviewed
Oct 21, 2020
|
|
||
| import java.util.Base64 | ||
|
|
||
| sealed trait MessageSystemAttribute |
Member
There was a problem hiding this comment.
I think this can be defined in the rest module, as that's the only place where it's used?
Contributor
Author
There was a problem hiding this comment.
Indeed, moved to rest module
* Moving MessageSystemAttribute to rest as it is used only in this module
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #376
TraceID is stored now as a part of message data. It can be received via request header (
X-Amzn-Trace-Id) or MessageSystemAttributes (AWSTraceHeader). I have added handling of MessageSystemAttributes toSendMessageDirectivesas it was missing.