Skip to content

Allow MessageGroupId for standard queues #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

Allow MessageGroupId for standard queues #1138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
799a03e
Allow MessageGroupId for standard queues (#1137)
sawadashota Jul 22, 2025
666f331
Update test to reflect that regular queues now allow MessageGroupId
sawadashota Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...esting-amazon-java-sdk/src/test/scala/org/elasticmq/rest/sqs/AmazonJavaSdkTestSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,10 +445,10 @@ class AmazonJavaSdkTestSuite extends SqsClientServerCommunication with Matchers
client.sendMessage(new SendMessageRequest(fifoQueueUrl, "A body"))
)

// Regular queues don't allow message groups
assertInvalidParameterQueueTypeException("MessageGroupId")(
client.sendMessage(new SendMessageRequest(regularQueueUrl, "A body").withMessageGroupId("group-1"))
)
// Regular queues now allow message groups
// Test that sending MessageGroupId to regular queue works
val result = client.sendMessage(new SendMessageRequest(regularQueueUrl, "A body").withMessageGroupId("group-1"))
result should not be null
}

test("FIFO queues do not support delaying individual messages") {
Expand Down
7 changes: 2 additions & 5 deletions rest/rest-sqs/src/main/scala/org/elasticmq/rest/sqs/SendMessageDirectives.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,17 +88,14 @@ trait SendMessageDirectives {
.fold(error => throw SQSException.invalidAttributeValue("MessageBody", Some(error)), identity)

val messageGroupId = parameters.MessageGroupId match {
// MessageGroupId is only supported for FIFO queues
case Some(v) if !queueData.isFifo => throw SQSException.invalidQueueTypeParameter(MessageGroupIdParameter)

// MessageGroupId is required for FIFO queues
case None if queueData.isFifo => throw SQSException.missingParameter(MessageGroupIdParameter)

// Ensure the given value is valid
// Ensure the given value is valid (for both FIFO and standard queues)
case Some(id) if !isValidFifoPropertyValue(id) =>
throw SQSException.invalidAlphanumericalPunctualParameterValue(MessageGroupIdParameter)

// This must be a correct value (or this isn't a FIFO queue and no value is required)
// This must be a correct value or None
case m => m
}

Expand Down