fix: crop children on macos platform #2718
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2705
In macOS, components do not properly clip their children without the changes in that PR. The PR introduces child clipping support for the element specifically on the macOS platform. These changes do not affect the iOS platform.
Test Plan
You can easily test that solution by running the Test2705
What's required for testing (prerequisites)?
Run the example, create a workspace with React Native SVG.
What are the steps to reproduce (after prerequisites)?
You can just run the test example without changes.
Compatibility
Checklist
README.md__tests__folder