feat: FeDropShadow #2514
Merged
feat: FeDropShadow #2514
+88
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakex7
added a commit
that referenced
this pull request
Oct 28, 2024
# Summary While working on #2514 I've noticed that negative dx/dy were treated as positive. ## Test Plan Add FeOffset filter with negative dx/dy to an element. It should move closer to upper left corner. ## Compatibility | OS | Implemented | | ------- | :---------: | | Android | ✅ |
jakex7
added a commit
that referenced
this pull request
Oct 28, 2024
# Summary While working on #2514 I've noticed a bug in `FeComposite` on Android that `in2` was ignored ## Test Plan Run Example app -> filters -> FeComposite on Android ## Compatibility | OS | Implemented | | ------- | :---------: | | Android | ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of #2362 introducing highly requested ✨
FeDropShadow✨ filter. This addition is straightforward since it's essentially a shorthand (as specified in the spec) for filters that are already implemented: https://www.w3.org/TR/filter-effects-1/#feDropShadowElementTest Plan
Example app -> Filters -> FeDropShadow
Compatibility