Skip to content

fix: client rect on use element #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: client rect on use element #2513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion android/src/main/java/com/horcrux/svg/UseView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import android.graphics.Matrix;
import android.graphics.Paint;
import android.graphics.Path;
import android.graphics.RectF;
import com.facebook.common.logging.FLog;
import com.facebook.react.bridge.Dynamic;
import com.facebook.react.bridge.ReactContext;
Expand Down Expand Up @@ -86,7 +87,11 @@ void draw(Canvas canvas, Paint paint, float opacity) {
template.draw(canvas, paint, opacity * mOpacity);
}

this.setClientRect(template.getClientRect());
// TODO: replace getMatrix with mCTM when it will be fixed
RectF clientRect = new RectF();
this.getPath(canvas, paint).computeBounds(clientRect, true);
canvas.getMatrix().mapRect(clientRect);
this.setClientRect(clientRect);

template.restoreCanvas(canvas, count);
if (template instanceof RenderableView) {
Expand Down
Loading