feat: support Fabric on Android #1804
Conversation
WoLewicki
changed the title
| public void setCx(String cx) { | ||
| mCx = SVGLength.from(cx); | ||
| invalidate(); | ||
| } | ||
|
|
There was a problem hiding this comment.
I think I remember you explaining problems with Dynamic and CodeGen. If that's the reason behind every setter being duplicated for String and Dynamic it would be great to have a comment explaining it somewhere.
There was a problem hiding this comment.
Good point. I will add a comment in the main PR's description.
mateosilguero
left a comment
mateosilguero
left a comment
There was a problem hiding this comment.
It tooks 15min but i works well for me 👍🏻
|
This is a great milestone! Are you also working on the iOS platform by any chance? |
|
@andyoh365 |
|
Thank you! |
|
Hi, when I yarn add this branch or the latest commit from this branch or the #add-fabric branch, I get the error message below. When I check react-native-svg folder under node_modules, the lib folder is missing, which exists in the latest stable version. Error: While trying to resolve module
|
|
Yeah, |
Most of Android changes for Fabric and bump of
FabricExampleto RN0.69.2.iOSandJSchanges are available in #1821.The most notable change on Android is adding methods to components that accept
Stringvalues of eachNumberPropinstead ofDynamic. Another change is changed structure ofRenderableViewManager.javasince we needed to abstract methods that belong only to components inheriting fromVirtualViewin order to be able to properly override them in their children.