review: 3412 - 1 #3414
Open
review: 3412 - 1 #3414
+134
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
This is just cleaner
accepted env vars. Detox `device.adbName` property expects values as listed by `adb devices` command. According to `adb --help` this is device "serial", hence the naming. This commit also drops E2E part of env vars, since it does not fit everywhere & doesn't seem reqruied. If we encounter some namespace conflicts we will consider adding it back. This code is an example. **THE RUNTIME HAS NOT BEEN TESTED**.
kkafar
force-pushed
the
@kkafar/3412-review-1
branch
from
59f8d6d to
766c755
Compare
Collaborator
|
I am going to cherry pick these changes but the last 2 commits (If you don't mind). I was going to dig down with android in a separate PR to keep #3412 lean |
Member
Author
|
Fine! |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@KrzysztofWojnar
Review suggestions for #3412.
Please note that I've not tested these changes. This is a skeleton / example code that is a good starting point for further work & polishing.
You can take this code as is (by simply merging this PR into your branch (as it is set up)) or apply the changes your self.
I've explained rationale where needed in messages of particular commits.