chore: update contributing guide #2140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboba
suggested changes
May 17, 2024
Contributor
tboba
left a comment
tboba
left a comment
There was a problem hiding this comment.
Great stuff! Left my review below 👇
Co-authored-by: Tymoteusz Boba <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
kkafar
reviewed
May 20, 2024
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
My initial impressions. I'll reiterate on this PR
guides/CONTRIBUTING.md
Outdated
|
|
||
| For commits and pull request names we follow a [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) specification. | ||
| > [!WARNING] | ||
| > Those steps are crucial, if you change the API in react-native-screens and won't merge react-navigation changes the libraries may go out of sync and crash i.e. because of not existing property. On the other hand, if you don't perform step 6 and 7, test examples and showcase app may stop working in react-native-screens. |
Member
There was a problem hiding this comment.
This is a bit exaggerated. Any backward compatible changes in react-native-screens, so changes in minor / patch versions should go unnoticed if react-navigation is not updated. Only breaking changes would break the behaviour and we're fine with that.
Contributor
Author
There was a problem hiding this comment.
So my idea was that the previous sections let you know if you need or do not need to open PR to react navigation. And if you need, you end up in this section. Then those steps are crucial (?). But I can rephrase that if it's not clear.
Co-authored-by: Kacper Kafara <[email protected]>
Co-authored-by: Kacper Kafara <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
Co-authored-by: Tymoteusz Boba <[email protected]>
Contributor
This was referenced Aug 20, 2024
This was referenced Aug 23, 2024
This was referenced Aug 30, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description Our contributing guide was very basic and written long time ago. I updated it with some more insights and details on how to start contributing to this project. --------- Co-authored-by: Tymoteusz Boba <[email protected]> Co-authored-by: Kacper Kafara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our contributing guide was very basic and written long time ago. I updated it with some more insights and details on how to start contributing to this project.