Skip to content

Conversation

@maciekstosio
Copy link
Contributor

@maciekstosio maciekstosio commented Apr 5, 2024

Description

This PR intents to bump yarn to the newest version (4.1.1). That's mostly because of not found node_modules directory inside react-navigation submodule. It seems that yarn v1 doesn't properly handle monorepos, so I bumped yarn to the latest stable.

Changes

Changes after running:

yarn set version stable

Test code and steps to reproduce

Clone repo, yarn, yarn submodules and cd TestsExample && yarn, the latest should finish successfully.

@maciekstosio maciekstosio requested a review from kkafar April 5, 2024 13:10
@tboba
Copy link
Contributor

tboba commented Apr 8, 2024

@maciekstosio Hmm, it seems that my yarn.lock is being modified when I'm executing yarn on your branch. Have you committed changes from that file? Do you have any changes on your environment? 😄

image

Copy link
Contributor

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @kkafar could you check if everything's okay there?

@tboba tboba changed the title Bump yarn to latest stable (4.1.1) chore: bump yarn to latest stable (4.1.1) Apr 16, 2024
@tboba
Copy link
Contributor

tboba commented Apr 16, 2024

Let's merge this for now 🎉

@tboba tboba merged commit 6b694e3 into main Apr 16, 2024
@tboba tboba deleted the @maciekstosio/Bump-yarn-to-4.1.1-(latest-stable-) branch April 16, 2024 13:59
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sorry missed notification. Looks fine! Only things I would address is using yarn run instead of npx to run scripts to keep things consistent.

Besides that we need someone to test how does our repo work now in following scenarios:

  1. Installing version directly from github branch (by putting "react-native-screens": "software-mansion/react-native-screens#<branch-name>" in package.json of application

  2. Cloning, running yarn & yarn prepare & trying to run test applications.

github-merge-queue bot referenced this pull request in valora-inc/wallet Apr 24, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-screens](https://togithub.com/software-mansion/react-native-screens)
| [`^3.30.1` ->
`^3.31.1`](https://renovatebot.com/diffs/npm/react-native-screens/3.30.1/3.31.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-screens/3.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-screens/3.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-screens/3.30.1/3.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-screens/3.30.1/3.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>software-mansion/react-native-screens
(react-native-screens)</summary>

###
[`v3.31.1`](https://togithub.com/software-mansion/react-native-screens/compare/3.31.0...7aa5e7b022d2aa55d05f752f7127a6d142b2b44b)

[Compare
Source](https://togithub.com/software-mansion/react-native-screens/compare/3.31.0...3.31.1)

###
[`v3.31.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.31.0)

[Compare
Source](https://togithub.com/software-mansion/react-native-screens/compare/3.30.1...3.31.0)

Minor release including adding support for React Native 0.74 and fixing
targets of the touchables on the JS Stack.
Thanks for following along! 💙

#### What's Changed

#### 🐛 Bug fixes

- Don't use AnimatedNativeScreen when stackPresentation prop is not set
by [@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[https://github.com/software-mansion/react-native-screens/pull/2107](https://togithub.com/software-mansion/react-native-screens/pull/2107)
- Change retrieving window in FullWindowOverlay by
[@&#8203;tboba](https://togithub.com/tboba) in
[https://github.com/software-mansion/react-native-screens/pull/2031](https://togithub.com/software-mansion/react-native-screens/pull/2031)

#### 🔢 Miscellaneous

- Bump yarn to latest stable (4.1.1) by
[@&#8203;maciekstosio](https://togithub.com/maciekstosio) in
[https://github.com/software-mansion/react-native-screens/pull/2097](https://togithub.com/software-mansion/react-native-screens/pull/2097)
- Add RCT-Image to RNScreens.podspec by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[https://github.com/software-mansion/react-native-screens/pull/2089](https://togithub.com/software-mansion/react-native-screens/pull/2089)
- Fix emit type parameters by
[@&#8203;mym0404](https://togithub.com/mym0404) in
[https://github.com/software-mansion/react-native-screens/pull/2087](https://togithub.com/software-mansion/react-native-screens/pull/2087)

#### New Contributors

- [@&#8203;mym0404](https://togithub.com/mym0404) made their first
contribution in
[https://github.com/software-mansion/react-native-screens/pull/2087](https://togithub.com/software-mansion/react-native-screens/pull/2087)
- [@&#8203;maciekstosio](https://togithub.com/maciekstosio) made their
first contribution in
[https://github.com/software-mansion/react-native-screens/pull/2097](https://togithub.com/software-mansion/react-native-screens/pull/2097)

#### 🙌 Thank you for your contributions!

**Full Changelog**:
software-mansion/react-native-screens@3.31.0-rc.1...3.31.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <[email protected]>
github-merge-queue bot referenced this pull request in valora-inc/wallet Apr 24, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-screens](https://togithub.com/software-mansion/react-native-screens)
| [`^3.30.1` ->
`^3.31.1`](https://renovatebot.com/diffs/npm/react-native-screens/3.30.1/3.31.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-screens/3.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-screens/3.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-screens/3.30.1/3.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-screens/3.30.1/3.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>software-mansion/react-native-screens
(react-native-screens)</summary>

###
[`v3.31.1`](https://togithub.com/software-mansion/react-native-screens/compare/3.31.0...7aa5e7b022d2aa55d05f752f7127a6d142b2b44b)

[Compare
Source](https://togithub.com/software-mansion/react-native-screens/compare/3.31.0...3.31.1)

###
[`v3.31.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.31.0)

[Compare
Source](https://togithub.com/software-mansion/react-native-screens/compare/3.30.1...3.31.0)

Minor release including adding support for React Native 0.74 and fixing
targets of the touchables on the JS Stack.
Thanks for following along! 💙

#### What's Changed

#### 🐛 Bug fixes

- Don't use AnimatedNativeScreen when stackPresentation prop is not set
by [@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[https://github.com/software-mansion/react-native-screens/pull/2107](https://togithub.com/software-mansion/react-native-screens/pull/2107)
- Change retrieving window in FullWindowOverlay by
[@&#8203;tboba](https://togithub.com/tboba) in
[https://github.com/software-mansion/react-native-screens/pull/2031](https://togithub.com/software-mansion/react-native-screens/pull/2031)

#### 🔢 Miscellaneous

- Bump yarn to latest stable (4.1.1) by
[@&#8203;maciekstosio](https://togithub.com/maciekstosio) in
[https://github.com/software-mansion/react-native-screens/pull/2097](https://togithub.com/software-mansion/react-native-screens/pull/2097)
- Add RCT-Image to RNScreens.podspec by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[https://github.com/software-mansion/react-native-screens/pull/2089](https://togithub.com/software-mansion/react-native-screens/pull/2089)
- Fix emit type parameters by
[@&#8203;mym0404](https://togithub.com/mym0404) in
[https://github.com/software-mansion/react-native-screens/pull/2087](https://togithub.com/software-mansion/react-native-screens/pull/2087)

#### New Contributors

- [@&#8203;mym0404](https://togithub.com/mym0404) made their first
contribution in
[https://github.com/software-mansion/react-native-screens/pull/2087](https://togithub.com/software-mansion/react-native-screens/pull/2087)
- [@&#8203;maciekstosio](https://togithub.com/maciekstosio) made their
first contribution in
[https://github.com/software-mansion/react-native-screens/pull/2097](https://togithub.com/software-mansion/react-native-screens/pull/2097)

#### 🙌 Thank you for your contributions!

**Full Changelog**:
software-mansion/react-native-screens@3.31.0-rc.1...3.31.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <[email protected]>
shottah referenced this pull request in Kolektivo/Kolektivo-Mobile-App May 15, 2024
…inc#5309)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-screens](https://togithub.com/software-mansion/react-native-screens)
| [`^3.30.1` ->
`^3.31.1`](https://renovatebot.com/diffs/npm/react-native-screens/3.30.1/3.31.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-screens/3.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-screens/3.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-screens/3.30.1/3.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-screens/3.30.1/3.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>software-mansion/react-native-screens
(react-native-screens)</summary>

###
[`v3.31.1`](https://togithub.com/software-mansion/react-native-screens/compare/3.31.0...7aa5e7b022d2aa55d05f752f7127a6d142b2b44b)

[Compare
Source](https://togithub.com/software-mansion/react-native-screens/compare/3.31.0...3.31.1)

###
[`v3.31.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.31.0)

[Compare
Source](https://togithub.com/software-mansion/react-native-screens/compare/3.30.1...3.31.0)

Minor release including adding support for React Native 0.74 and fixing
targets of the touchables on the JS Stack.
Thanks for following along! 💙

#### What's Changed

#### 🐛 Bug fixes

- Don't use AnimatedNativeScreen when stackPresentation prop is not set
by [@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[https://github.com/software-mansion/react-native-screens/pull/2107](https://togithub.com/software-mansion/react-native-screens/pull/2107)
- Change retrieving window in FullWindowOverlay by
[@&#8203;tboba](https://togithub.com/tboba) in
[https://github.com/software-mansion/react-native-screens/pull/2031](https://togithub.com/software-mansion/react-native-screens/pull/2031)

#### 🔢 Miscellaneous

- Bump yarn to latest stable (4.1.1) by
[@&#8203;maciekstosio](https://togithub.com/maciekstosio) in
[https://github.com/software-mansion/react-native-screens/pull/2097](https://togithub.com/software-mansion/react-native-screens/pull/2097)
- Add RCT-Image to RNScreens.podspec by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[https://github.com/software-mansion/react-native-screens/pull/2089](https://togithub.com/software-mansion/react-native-screens/pull/2089)
- Fix emit type parameters by
[@&#8203;mym0404](https://togithub.com/mym0404) in
[https://github.com/software-mansion/react-native-screens/pull/2087](https://togithub.com/software-mansion/react-native-screens/pull/2087)

#### New Contributors

- [@&#8203;mym0404](https://togithub.com/mym0404) made their first
contribution in
[https://github.com/software-mansion/react-native-screens/pull/2087](https://togithub.com/software-mansion/react-native-screens/pull/2087)
- [@&#8203;maciekstosio](https://togithub.com/maciekstosio) made their
first contribution in
[https://github.com/software-mansion/react-native-screens/pull/2097](https://togithub.com/software-mansion/react-native-screens/pull/2097)

#### 🙌 Thank you for your contributions!

**Full Changelog**:
software-mansion/react-native-screens@3.31.0-rc.1...3.31.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <[email protected]>
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
## Description

This PR intents to bump yarn to the newest version (4.1.1). That's
mostly because of not found node_modules directory inside
`react-navigation` submodule. It seems that yarn v1 doesn't properly
handle monorepos, so I bumped yarn to the latest stable.

## Changes

Changes after running:

```
yarn set version stable
```

## Test code and steps to reproduce

Clone repo, `yarn`, `yarn submodules` and `cd TestsExample && yarn`, the
latest should finish successfully.

---------

Co-authored-by: tboba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants