fix(iOS): Fix screen traversing on Fabric, update React Native to rc.6 #2090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboba
changed the title
This was referenced May 22, 2024
This was referenced May 25, 2024
This was referenced Jun 3, 2024
This was referenced Jun 11, 2024
This was referenced Jul 17, 2024
This was referenced Jul 25, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
software-mansion#2090) ## Description Some time ago, I've introduced a [fix](software-mansion@3b35894#diff-547f3e256039a77611e8a361cd680f6c4ddd17f1e057dea113777001a7b37cc3R617) for Fabric for scenario, when user tries to navigate to two (or more) different screens at the same time. Unfortunately, regression shows that it's not possible for now to navigate on more than one screen, because of this change. This PR reverts that change. ## Changes - Reverted a fix for navigating to more than one screen at the same time - Updated React Native in FabricTestExample to 0.74.0-rc.6 ## Screenshots / GIFs ### Before https://github.com/software-mansion/react-native-screens/assets/23281839/779d1b43-56ae-4a55-8fc5-0594093ce884 ### After https://github.com/software-mansion/react-native-screens/assets/23281839/ea9e421d-0fad-457c-a374-9fec5aba9f53 ## Test code and steps to reproduce You can use `Test1726` in FabricTestExample to reproduce this scenario and test that change. ## Checklist - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some time ago, I've introduced a fix for Fabric for scenario, when user tries to navigate to two (or more) different screens at the same time. Unfortunately, regression shows that it's not possible for now to navigate on more than one screen, because of this change. This PR reverts that change.
Changes
Screenshots / GIFs
Before
Screen.Recording.2024-04-03.at.15.52.44.mov
After
Screen.Recording.2024-04-03.at.15.48.29.mov
Test code and steps to reproduce
You can use
Test1726in FabricTestExample to reproduce this scenario and test that change.Checklist