Add round and color nodes #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatiPl01
added a commit
that referenced
this pull request
Jan 21, 2025
…elative units (#15) * Fix crash on component unmount * Fix re-render crash, add proper types to the animated component style prop * Remove unnecessary log * Remove unnecessary field * Apply review suggestions * Small change * Add return for non-fabric
MatiPl01
added a commit
that referenced
this pull request
Jan 21, 2025
…elative units (#15) * Fix crash on component unmount * Fix re-render crash, add proper types to the animated component style prop * Remove unnecessary log * Remove unnecessary field * Apply review suggestions * Small change * Add return for non-fabric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new "round" and "color" nodes.
Color nodes can be used to map to color props in view (e.g. backgroundColor)
Round is required for the color math to function properly (each color component needs to be an integer).
Added demo app where you can pan view around that changes color depending on the position on HSV palette.