Skip to content

[iOS] Fix Animated events with no native driver #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2025
+19 −3
Merged

[iOS] Fix Animated events with no native driver #3841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
308c27a
Fix Animated events with no native driver
j-piasecki Nov 26, 2025
8f659bc
Move cast
j-piasecki Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/react-native-gesture-handler/apple/RNGestureHandlerDetector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ NS_ASSUME_NONNULL_BEGIN

- (void)dispatchGestureEvent:(RNGestureHandlerDetectorEventEmitter::OnGestureHandlerEvent)event;

- (void)dispatchAnimatedGestureEvent:(RNGestureHandlerDetectorEventEmitter::OnGestureHandlerEvent)event;

- (void)dispatchTouchEvent:(RNGestureHandlerDetectorEventEmitter::OnGestureHandlerTouchEvent)event;

- (void)dispatchReanimatedStateChangeEvent:
Expand Down
11 changes: 11 additions & 0 deletions packages/react-native-gesture-handler/apple/RNGestureHandlerDetector.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,17 @@ - (void)dispatchGestureEvent:(RNGestureHandlerDetectorEventEmitter::OnGestureHan
}
}

- (void)dispatchAnimatedGestureEvent:(RNGestureHandlerDetectorEventEmitter::OnGestureHandlerEvent)event
{
if (_eventEmitter != nullptr) {
std::dynamic_pointer_cast<const RNGestureHandlerDetectorEventEmitter>(_eventEmitter)->onGestureHandlerAnimatedEvent({
.state = event.state,
.handlerTag = event.handlerTag,
.handlerData = event.handlerData,
});
}
}

- (void)dispatchTouchEvent:(RNGestureHandlerDetectorEventEmitter::OnGestureHandlerTouchEvent)event
{
if (_eventEmitter != nullptr) {
Expand Down
9 changes: 6 additions & 3 deletions packages/react-native-gesture-handler/apple/RNGestureHandlerManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,18 +464,21 @@ - (void)sendNativeOrVirtualEvent:(RNGestureHandlerStateChange *)event
forView:(RNGHUIView *)detectorView
{
if ([event isKindOfClass:[RNGestureHandlerEvent class]]) {
RNGestureHandlerEvent *gestureEvent = (RNGestureHandlerEvent *)event;

switch (eventHandlerType) {
case RNGestureHandlerEventHandlerTypeAnimated:
case RNGestureHandlerEventHandlerTypeAnimated: {
[self sendEventForNativeAnimatedEvent:event];
auto nativeEvent = [gestureEvent getNativeEvent];
[(RNGestureHandlerDetector *)detectorView dispatchAnimatedGestureEvent:nativeEvent];
break;
}
case RNGestureHandlerEventHandlerTypeReanimated: {
RNGestureHandlerEvent *gestureEvent = (RNGestureHandlerEvent *)event;
auto nativeEvent = [gestureEvent getReanimatedNativeEvent];
[(RNGestureHandlerDetector *)detectorView dispatchReanimatedGestureEvent:nativeEvent];
break;
}
case RNGestureHandlerEventHandlerTypeJS: {
RNGestureHandlerEvent *gestureEvent = (RNGestureHandlerEvent *)event;
auto nativeEvent = [gestureEvent getNativeEvent];
[(RNGestureHandlerDetector *)detectorView dispatchGestureEvent:nativeEvent];
break;
Expand Down
Loading