[General] Unwrap handlerData when passing event to user-defined callbacks
#3840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bert
approved these changes
Nov 26, 2025
Contributor
m-bert
left a comment
m-bert
left a comment
There was a problem hiding this comment.
Those are some loooooong type names 😅
packages/react-native-gesture-handler/src/v3/hooks/useGestureCallbacks.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to how codegen is structured, we rely on a dynamic
handlerDatafield in events so we don't have to define an event handler for each event type we may be sending. Currently, this is reflected in the API - when reading data from events, it needs to be read fromhandlerData.This PR adds flattened types and a flatten step to get rid of that step, so that data can be read directly from the event.
This doesn't impact animated, so the event mapping there needs to include both
nativeEventandhandlerData.Test plan
console.logthe events