-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix inner styling of Pressable #2982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
734c429
add flex styling example
latekvo 923b95c
add initial inner style extraction
latekvo aa493dd
split styleProp into inner and outer styles
latekvo 7aa9566
update example
latekvo 95d06cd
add custom type utility
latekvo b83faa9
fix babel import/export errors
latekvo c848804
[unsafe] initial working version
latekvo 4e26276
fixed insufficient outer styles deletion, fixed clarity, fixed most t…
latekvo a1f0f2c
move style manipulating functions to utils
latekvo 9d4446a
change types to remove more errors
latekvo 4c75fa7
flatten styles, remove web issues
latekvo 6af3cd1
remove pressable import error, fix types
latekvo 9f471cc
fix typing issues on extractStyles
latekvo 36f1a24
imporve variable names
latekvo 4b799d1
remove temporary styling example
latekvo 01348b4
remove unnecessary comment
latekvo 4a7a00e
add source clarification for inner style keys
latekvo 12a69f8
remove outer style from the inner style keys
latekvo f00a18a
convert for-of loops into function streams
latekvo c1933eb
Merge branch 'main' into @latekvo/fix-pressable-flex-styling
latekvo 83efbed
apply style splitting change proposals
latekvo 5595026
combine style splitting into a single function
latekvo 259f0d3
fix dependency array lints
latekvo e348d8f
combine both inner and outer key separation into a single pass
latekvo 9aa0c0f
remove unnecessary exports
latekvo f612444
Merge remote-tracking branch 'origin/main' into @latekvo/fix-pressabl…
latekvo b3278cc
remove unncessary Gesture flag
latekvo 75d4109
change style splitting from streams to for loop
latekvo 4846fd7
remove unnecessary type casts
latekvo 60b77b9
remove unnecessary null check
latekvo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.